From b0211b434a7ff376e2e835622efd1636275db264 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Tue, 1 Sep 2020 13:08:38 -0700 Subject: [PATCH] fix the issue that error dialog is not showing (#12061) --- .../services/errorMessage/browser/errorMessageDialog.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/sql/workbench/services/errorMessage/browser/errorMessageDialog.ts b/src/sql/workbench/services/errorMessage/browser/errorMessageDialog.ts index a18571cc66..25deed7945 100644 --- a/src/sql/workbench/services/errorMessage/browser/errorMessageDialog.ts +++ b/src/sql/workbench/services/errorMessage/browser/errorMessageDialog.ts @@ -75,9 +75,11 @@ export class ErrorMessageDialog extends Modal { private createCopyButton() { let copyButtonLabel = localize('copyDetails', "Copy details"); - if (this._messageDetails) { - this._copyButton = this.addFooterButton(copyButtonLabel, () => this._clipboardService.writeText(this._messageDetails!).catch(err => onUnexpectedError(err)), 'left'); - } + this._copyButton = this.addFooterButton(copyButtonLabel, () => { + if (this._messageDetails) { + this._clipboardService.writeText(this._messageDetails!).catch(err => onUnexpectedError(err)); + } + }, 'left'); this._copyButton!.icon = 'codicon scriptToClipboard'; this._copyButton!.element.title = copyButtonLabel; this._register(attachButtonStyler(this._copyButton!, this._themeService, { buttonBackground: SIDE_BAR_BACKGROUND, buttonHoverBackground: SIDE_BAR_BACKGROUND, buttonForeground: SIDE_BAR_FOREGROUND }));