From b0b1b59147217d512a4f377e59c7e12a8a2ab3e2 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Wed, 26 Jun 2019 15:35:52 -0700 Subject: [PATCH] Fix #6175: Schema compare doesn't always use scmp options (#6176) * remove resetting options to dialog options before comparing * bump azdata dependency version --- extensions/schema-compare/package.json | 2 +- extensions/schema-compare/src/schemaCompareResult.ts | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/extensions/schema-compare/package.json b/extensions/schema-compare/package.json index a1c0776ee1..2061085e6d 100644 --- a/extensions/schema-compare/package.json +++ b/extensions/schema-compare/package.json @@ -7,7 +7,7 @@ "preview": true, "engines": { "vscode": "^1.25.0", - "azdata": ">=1.8.0" + "azdata": ">=1.9.0" }, "license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/extensions/import/Microsoft_SQL_Server_Import_Extension_and_Tools_Import_Flat_File_Preview.docx", "icon": "images/sqlserver.png", diff --git a/extensions/schema-compare/src/schemaCompareResult.ts b/extensions/schema-compare/src/schemaCompareResult.ts index 02edb548a3..31d6fcb920 100644 --- a/extensions/schema-compare/src/schemaCompareResult.ts +++ b/extensions/schema-compare/src/schemaCompareResult.ts @@ -267,10 +267,6 @@ export class SchemaCompareResult { } public async execute(): Promise { - if (this.schemaCompareOptionDialog && this.schemaCompareOptionDialog.deploymentOptions) { - // take updates if any - this.deploymentOptions = this.schemaCompareOptionDialog.deploymentOptions; - } Telemetry.sendTelemetryEvent('SchemaComparisonStarted'); const service = await SchemaCompareResult.getService(msSqlProvider); if (!this.operationId) {