From b1e0b7c1e32f54b305ee0a49e3db927e075a2d95 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Thu, 24 Oct 2019 16:43:52 -0700 Subject: [PATCH] Always send \n instead of \r\n to Jupyter kernel (#7995) * Always send \n instead of \r\n to kernel * Use replace instead of split/join --- extensions/notebook/src/jupyter/jupyterKernel.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/extensions/notebook/src/jupyter/jupyterKernel.ts b/extensions/notebook/src/jupyter/jupyterKernel.ts index 5a2de73e02..8658ed040e 100644 --- a/extensions/notebook/src/jupyter/jupyterKernel.ts +++ b/extensions/notebook/src/jupyter/jupyterKernel.ts @@ -87,6 +87,8 @@ export class JupyterKernel implements nb.IKernel { } requestExecute(content: nb.IExecuteRequest, disposeOnDone?: boolean): nb.IFuture { + content.code = Array.isArray(content.code) ? content.code.join('') : content.code; + content.code = content.code.replace(/\r+\n/gm, '\n'); // Remove \r (if it exists) from newlines let futureImpl = this.kernelImpl.requestExecute(content as KernelMessage.IExecuteRequest, disposeOnDone); return new JupyterFuture(futureImpl); }