ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

removing feature specific query plan flag (#18330)

Browse Source
This commit is contained in:
Aasim Khan
2022-02-11 14:17:39 -08:00
committed by GitHub
parent b65e6d0bab
commit b25935f8a5
2 changed files with 1 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/sql/workbench/contrib/queryplan2/browser/queryPlan.ts
View File

@@ -8,8 +8,6 @@ import type * as azdata from 'azdata';
import { IPanelView, IPanelTab } from 'sql/base/browser/ui/panel/panel'; import { IPanelView, IPanelTab } from 'sql/base/browser/ui/panel/panel';
import { localize } from 'vs/nls'; import { localize } from 'vs/nls';
import { dispose } from 'vs/base/common/lifecycle'; import { dispose } from 'vs/base/common/lifecycle';
import { IConfigurationRegistry, Extensions as ConfigExtensions } from 'vs/platform/configuration/common/configurationRegistry';
import { Registry } from 'vs/platform/registry/common/platform';
import { ActionBar } from 'sql/base/browser/ui/taskbar/actionbar'; import { ActionBar } from 'sql/base/browser/ui/taskbar/actionbar';
import * as DOM from 'vs/base/browser/dom'; import * as DOM from 'vs/base/browser/dom';
import * as azdataGraphModule from 'azdataGraph'; import * as azdataGraphModule from 'azdataGraph';
@@ -620,24 +618,3 @@ registerThemingParticipant((theme: IColorTheme, collector: ICssStyleCollector) =
`); `);
} }
}); });
/**
* Registering a feature flag for query plan.
* TODO: This should be removed before taking the feature to public preview.
*/
const QUERYPLAN2_CONFIG_ID = 'queryPlan2';
Registry.as<IConfigurationRegistry>(ConfigExtensions.Configuration).registerConfiguration({
id: QUERYPLAN2_CONFIG_ID,
title: localize('queryPlan2.configTitle', "Query Plan"),
type: 'object',
properties: {
'queryPlan2.enableFeature': {
'type': 'boolean',
'default': false,
'description': localize('queryPlan2.featureEnabledDescription', "Controls whether the new query plan feature is enabled. Default value is false.")
}
}
});

2
src/sql/workbench/services/query/common/queryManagement.ts
View File

@@ -331,7 +331,7 @@ export class QueryManagementService implements IQueryManagementService {
public onResultSetUpdated(resultSetInfo: azdata.QueryExecuteResultSetNotificationParams): void { public onResultSetUpdated(resultSetInfo: azdata.QueryExecuteResultSetNotificationParams): void {
this._notify(resultSetInfo.ownerUri, (runner: QueryRunner) => { this._notify(resultSetInfo.ownerUri, (runner: QueryRunner) => {
runner.handleResultSetUpdated(resultSetInfo.resultSetSummary); runner.handleResultSetUpdated(resultSetInfo.resultSetSummary);
if (resultSetInfo.executionPlans && this._configurationService.getValue('queryPlan2.enableFeature')) { if (resultSetInfo.executionPlans && this._configurationService.getValue('workbench.enablePreviewFeatures')) {
runner.handleQueryPlan2Available(resultSetInfo.executionPlans); runner.handleQueryPlan2Available(resultSetInfo.executionPlans);
} }
}); });