From b2b7d18802ec3f2632b3d626c1eba3f4b7794fda Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Wed, 13 Mar 2019 09:59:19 -0700 Subject: [PATCH] Change Kernels Dropdown to show Switching instead of Loading On Kernel Change (#4426) Change Kernels Dropdown to show Changing instead of Loading On Kernel Change --- src/sql/parts/notebook/notebookActions.ts | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/sql/parts/notebook/notebookActions.ts b/src/sql/parts/notebook/notebookActions.ts index 327abd2dfc..7bb811ee84 100644 --- a/src/sql/parts/notebook/notebookActions.ts +++ b/src/sql/parts/notebook/notebookActions.ts @@ -23,13 +23,14 @@ import { noKernel } from 'sql/workbench/services/notebook/common/sessionManager' import { IConnectionDialogService } from 'sql/workbench/services/connection/common/connectionDialogService'; import { NotebookModel } from 'sql/parts/notebook/models/notebookModel'; -const msgLoading = localize('loading', 'Loading kernels...'); -const kernelLabel: string = localize('Kernel', 'Kernel: '); -const attachToLabel: string = localize('AttachTo', 'Attach to: '); -const msgLoadingContexts = localize('loadingContexts', 'Loading contexts...'); -const msgAddNewConnection = localize('addNewConnection', 'Add new connection'); -const msgSelectConnection = localize('selectConnection', 'Select connection'); -const msgLocalHost = localize('localhost', 'localhost'); +const msgLoading = localize('loading', "Loading kernels..."); +const msgChanging = localize('changing', "Changing kernel..."); +const kernelLabel: string = localize('Kernel', "Kernel: "); +const attachToLabel: string = localize('AttachTo', "Attach to: "); +const msgLoadingContexts = localize('loadingContexts', "Loading contexts..."); +const msgAddNewConnection = localize('addNewConnection', "Add new connection"); +const msgSelectConnection = localize('selectConnection', "Select connection"); +const msgLocalHost = localize('localhost', "localhost"); const HIDE_ICON_CLASS = ' hideIcon'; // Action to add a cell to notebook based on cell type(code/markdown). @@ -250,7 +251,7 @@ export class KernelsDropdown extends SelectBox { } public doChangeKernel(displayName: string): void { - this.setOptions([msgLoading], 0); + this.setOptions([msgChanging], 0); this.model.changeKernel(displayName); } }