ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a console error raised from error dialog action (#22124)

Browse Source
This commit is contained in:
Cheena Malhotra
2023-03-02 21:02:31 -08:00
committed by GitHub
parent 375ce82b7d
commit b310e3eed4
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/workbench/services/errorMessage/browser/errorMessageDialog.ts
View File

@@ -46,7 +46,7 @@ export class ErrorMessageDialog extends Modal {
private _okLabel: string; private _okLabel: string;
private _closeLabel: string; private _closeLabel: string;
private _readMoreLabel: string; private _readMoreLabel: string;
private _promiseResolver: (value: string) => void; private _promise: Deferred<string> | undefined;
private _onOk = new Emitter<void>(); private _onOk = new Emitter<void>();
public onOk: Event<void> = this._onOk.event; public onOk: Event<void> = this._onOk.event;
@@ -113,7 +113,7 @@ export class ErrorMessageDialog extends Modal {
// Run the action if possible // Run the action if possible
this._actions[index].run(); this._actions[index].run();
// Resolve promise after running action. // Resolve promise after running action.
this._promiseResolver(actionId); this._promise?.resolve(actionId);
} }
} }
@@ -175,7 +175,7 @@ export class ErrorMessageDialog extends Modal {
this._telemetryService.sendActionEvent(this._telemetryView, hideReason.toString()); this._telemetryService.sendActionEvent(this._telemetryView, hideReason.toString());
this.hide(hideReason); this.hide(hideReason);
if (resolvePromise) { if (resolvePromise) {
this._promiseResolver(hideReason.toString()); this._promise?.resolve(hideReason.toString());
} }
} }
@@ -242,8 +242,8 @@ export class ErrorMessageDialog extends Modal {
options.instructionText, options.readMoreLink, false); options.instructionText, options.readMoreLink, false);
const deferred = new Deferred<string | undefined>(); const deferred = new Deferred<string | undefined>();
this._promiseResolver = deferred.resolve; this._promise = deferred;
return deferred.promise; return this._promise.promise;
} }
private convertToSeverity(messageLevel: MessageLevel): Severity { private convertToSeverity(messageLevel: MessageLevel): Severity {