Refact/idea lastknown (#501)

* close

* connection is working

* formatting

* adds all

* formatting

* removed unneeded logging

* readd npm shrinkwrap

* addressed comments

* fix capabilities cacheing

* updated shrinkwrap

* fixed tests

* remove dead code

* vbump sqltools

src/sqltest/stubs/capabilitiesTestService.ts

@@ -9,6 +9,7 @@ import { ConnectionManagementInfo } from 'sql/parts/connection/common/connection
 import { ICapabilitiesService } from 'sql/services/capabilities/capabilitiesService';
 import Event from 'vs/base/common/event';
 import { Action } from 'vs/base/common/actions';
+import { ConnectionOptionSpecialType } from 'sql/workbench/api/common/sqlExtHostTypes';
 
 
 export class CapabilitiesTestService implements ICapabilitiesService {
@@ -33,7 +34,7 @@ export class CapabilitiesTestService implements ICapabilitiesService {
 					defaultValue: undefined,
 					isIdentity: true,
 					isRequired: true,
-					specialValueType: 0,
+					specialValueType: ConnectionOptionSpecialType.serverName,
 					valueType: 0
 				},
 				{
@@ -45,7 +46,7 @@ export class CapabilitiesTestService implements ICapabilitiesService {
 					defaultValue: undefined,
 					isIdentity: true,
 					isRequired: true,
-					specialValueType: 1,
+					specialValueType: ConnectionOptionSpecialType.databaseName,
 					valueType: 0
 				},
 				{
@@ -57,7 +58,7 @@ export class CapabilitiesTestService implements ICapabilitiesService {
 					defaultValue: undefined,
 					isIdentity: true,
 					isRequired: true,
-					specialValueType: 3,
+					specialValueType: ConnectionOptionSpecialType.userName,
 					valueType: 0
 				},
 				{
@@ -69,7 +70,7 @@ export class CapabilitiesTestService implements ICapabilitiesService {
 					defaultValue: undefined,
 					isIdentity: true,
 					isRequired: true,
-					specialValueType: 2,
+					specialValueType: ConnectionOptionSpecialType.authType,
 					valueType: 0
 				},
 				{
@@ -81,7 +82,7 @@ export class CapabilitiesTestService implements ICapabilitiesService {
 					defaultValue: undefined,
 					isIdentity: true,
 					isRequired: true,
-					specialValueType: 4,
+					specialValueType: ConnectionOptionSpecialType.password,
 					valueType: 0
 				}
 			]

src/sqltest/stubs/connectionProviderStub.ts

@@ -3,10 +3,10 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import data = require('data');
+import * as data from 'data';
 
 export class ConnectionProviderStub implements data.ConnectionProvider {
-	handle: number = 1;
+	public readonly providerId = 'MSSQL';
 
 	connect(connectionUri: string, connectionInfo: data.ConnectionInfo): Thenable<boolean> {
 		return undefined;

src/sqltest/stubs/objectExplorerProviderTestService.ts

@@ -8,6 +8,8 @@ import data = require('data');
 
 export class ObjectExplorerProviderTestService implements data.ObjectExplorerProvider {
 
+	public readonly providerId = 'MSSQL';
+
 	public createNewSession(connInfo: data.ConnectionInfo): Thenable<data.ObjectExplorerCloseSessionResponse> {
 		return Promise.resolve(undefined);
 	}