Improve notebook link handling (#6087)

* Improve notebook link handling
- Single click now works for links inside Output areas
- Command links in untrusted notebooks have link color
- Refactored to use directive so code is in 1 place and can be easily
  added elsewhere if needed

* Removed unneeded service from constructor
This commit is contained in:
Kevin Cunnane
2019-06-20 11:40:12 -07:00
committed by GitHub
parent 578ac6cae5
commit b37b14eabd
7 changed files with 82 additions and 62 deletions

View File

@@ -13,7 +13,6 @@ import { IBootstrapParams, ISelector, providerIterator } from 'sql/platform/boot
import { CommonServiceInterface } from 'sql/platform/bootstrap/node/commonServiceInterface.service';
import { EditableDropDown } from 'sql/platform/electron-browser/editableDropdown/editableDropdown.component';
import { NotebookComponent } from 'sql/workbench/parts/notebook/notebook.component';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { CodeComponent } from 'sql/workbench/parts/notebook/cellViews/code.component';
import { CodeCellComponent } from 'sql/workbench/parts/notebook/cellViews/codeCell.component';
@@ -26,6 +25,7 @@ import LoadingSpinner from 'sql/workbench/electron-browser/modelComponents/loadi
import { Checkbox } from 'sql/base/electron-browser/ui/checkbox/checkbox.component';
import { SelectBox } from 'sql/platform/ui/electron-browser/selectBox/selectBox.component';
import { InputBox } from 'sql/base/electron-browser/ui/inputBox/inputBox.component';
import { LinkHandlerDirective } from 'sql/workbench/parts/notebook/cellViews/linkHandler.directive';
export const NotebookModule = (params, selector: string, instantiationService: IInstantiationService): any => {
@NgModule({
@@ -43,7 +43,8 @@ export const NotebookModule = (params, selector: string, instantiationService: I
ComponentHostDirective,
OutputAreaComponent,
OutputComponent,
StdInComponent
StdInComponent,
LinkHandlerDirective
],
entryComponents: [NotebookComponent],
imports: [