ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update missed connection management return values (#14722)

Browse Source
This commit is contained in:
Charles Gagnon
2021-03-15 09:24:43 -07:00
committed by GitHub
parent 9df7c6c1aa
commit b3e141a150
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/services/connection/browser/connectionManagementService.ts
View File

@@ -659,7 +659,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
return this._connectionStatusManager.getActiveConnectionProfiles(providers); return this._connectionStatusManager.getActiveConnectionProfiles(providers);
} }
public getConnectionUriFromId(connectionId: string): string { public getConnectionUriFromId(connectionId: string): string | undefined {
let connectionInfo = this._connectionStatusManager.findConnectionByProfileId(connectionId); let connectionInfo = this._connectionStatusManager.findConnectionByProfileId(connectionId);
if (connectionInfo) { if (connectionInfo) {
return connectionInfo.ownerUri; return connectionInfo.ownerUri;
@@ -676,7 +676,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
}); });
} }
public getAdvancedProperties(): azdata.ConnectionOption[] { public getAdvancedProperties(): azdata.ConnectionOption[] | undefined {
let providers = this._capabilitiesService.providers; let providers = this._capabilitiesService.providers;
if (providers) { if (providers) {
@@ -775,7 +775,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
} }
} }
public getDefaultProviderId(): string { public getDefaultProviderId(): string | undefined {
let defaultProvider = WorkbenchUtils.getSqlConfigValue<string>(this._configurationService, Constants.defaultEngine); let defaultProvider = WorkbenchUtils.getSqlConfigValue<string>(this._configurationService, Constants.defaultEngine);
return defaultProvider && this._providers.has(defaultProvider) ? defaultProvider : undefined; return defaultProvider && this._providers.has(defaultProvider) ? defaultProvider : undefined;
} }
@@ -1226,7 +1226,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.findConnection(fileUri) : undefined; return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.findConnection(fileUri) : undefined;
} }
public listDatabases(connectionUri: string): Thenable<azdata.ListDatabasesResult> { public listDatabases(connectionUri: string): Thenable<azdata.ListDatabasesResult | undefined> {
const self = this; const self = this;
if (self.isConnected(connectionUri)) { if (self.isConnected(connectionUri)) {
return self.sendListDatabasesRequest(connectionUri); return self.sendListDatabasesRequest(connectionUri);