ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add notebook file icon support (#4419)

Browse Source 
- Added to both built-in themes. Long term would be good to contribute this back to Seti so it works without a carbon edit tag.
- Issue #4418 tracks remaining problem where for new notebooks it's not set initially. This is blocked by Raj's work so will update once that lands.
This commit is contained in:
Kevin Cunnane
2019-03-12 21:23:43 -07:00
committed by GitHub
parent 58e5125cde
commit b495fb7a37
8 changed files with 42 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/azurecore/package.json
View File

@@ -1,7 +1,7 @@
{ {
"name": "azurecore", "name": "azurecore",
"displayName": "%azure.displayName%", "displayName": "%azure.displayName%",
"description": "%azure.description", "description": "%azure.description%",
"version": "0.1.0", "version": "0.1.0",
"publisher": "Microsoft", "publisher": "Microsoft",
"preview": true, "preview": true,

1
extensions/theme-defaults/fileicons/images/notebook.svg Executable file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><title>notebook</title><path d="M15.5,2V15H.5V2h2V1h3a4.19,4.19,0,0,1,1.32.21A3.87,3.87,0,0,1,8,1.84a3.87,3.87,0,0,1,1.18-.63A4.19,4.19,0,0,1,10.5,1h3V2ZM1.5,14H7.8a4.43,4.43,0,0,0-.51-.43,3.41,3.41,0,0,0-.54-.31,2.74,2.74,0,0,0-.59-.2A3.2,3.2,0,0,0,5.5,13h-3V3h-1Zm2-2h2a4.18,4.18,0,0,1,1,.13,4,4,0,0,1,1,.39V2.72a3,3,0,0,0-.94-.54A3.15,3.15,0,0,0,5.5,2h-2Zm11-9h-1V13h-3a3.2,3.2,0,0,0-.67.07,2.74,2.74,0,0,0-.59.2,3.41,3.41,0,0,0-.54.31A4.43,4.43,0,0,0,8.2,14h6.3Zm-4-1a3.15,3.15,0,0,0-1.06.18,3,3,0,0,0-.94.54v9.8a4,4,0,0,1,1-.39,4.18,4.18,0,0,1,1-.13h2V2Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 661 B

1
extensions/theme-defaults/fileicons/images/notebook_inverse.svg Executable file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.cls-1{fill:#fff;}</style></defs><title>notebook_inverse</title><path class="cls-1" d="M15.46,2V15H.46V2h2V1h3a4.19,4.19,0,0,1,1.32.21A3.87,3.87,0,0,1,8,1.84a3.87,3.87,0,0,1,1.18-.63A4.19,4.19,0,0,1,10.46,1h3V2Zm-14,12h6.3a4.43,4.43,0,0,0-.51-.43,3.41,3.41,0,0,0-.54-.31,2.74,2.74,0,0,0-.59-.2A3.2,3.2,0,0,0,5.46,13h-3V3h-1Zm2-2h2a4.18,4.18,0,0,1,1,.13,4,4,0,0,1,1,.39V2.72a3,3,0,0,0-.94-.54A3.15,3.15,0,0,0,5.46,2h-2Zm11-9h-1V13h-3a3.2,3.2,0,0,0-.67.07,2.74,2.74,0,0,0-.59.2,3.41,3.41,0,0,0-.54.31,4.43,4.43,0,0,0-.51.43h6.3Zm-4-1a3.15,3.15,0,0,0-1.06.18,3,3,0,0,0-.94.54v9.8a4,4,0,0,1,1-.39,4.18,4.18,0,0,1,1-.13h2V2Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 734 B

10
extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json
View File

@@ -29,6 +29,12 @@
}, },
"_file_light": { "_file_light": {
"iconPath": "./images/Document_16x.svg" "iconPath": "./images/Document_16x.svg"
},
"notebook": {
"iconPath": "./images/notebook.svg"
},
"notebook_dark": {
"iconPath": "./images/notebook_inverse.svg"
} }
}, },
@@ -39,12 +45,14 @@
"rootFolder": "_root_folder_dark", "rootFolder": "_root_folder_dark",
"fileExtensions": { "fileExtensions": {
// icons by file extension // icons by file extension
"ipynb": "notebook_dark"
}, },
"fileNames": { "fileNames": {
// icons by file name // icons by file name
}, },
"languageIds": { "languageIds": {
// icons by language id // icons by language id
"notebook": "notebook_dark"
}, },
"light": { "light": {
"folderExpanded": "_folder_open_light", "folderExpanded": "_folder_open_light",
@@ -54,12 +62,14 @@
"file": "_file_light", "file": "_file_light",
"fileExtensions": { "fileExtensions": {
// icons by file extension // icons by file extension
"ipynb": "notebook"
}, },
"fileNames": { "fileNames": {
// icons by file name // icons by file name
}, },
"languageIds": { "languageIds": {
// icons by language id // icons by language id
"notebook": "notebook"
} }
}, },
"highContrast": { "highContrast": {

7
extensions/theme-defaults/package.json
View File

@@ -14,5 +14,12 @@
"path": "./themes/hc_black.json" "path": "./themes/hc_black.json"
} }
] ]
},
"iconThemes": [
{
"id": "vs-minimal",
"label": "Minimal (Azure Data Studio)",
"path": "./fileicons/vs_minimal-icon-theme.json"
} }
]
} }

1
extensions/theme-seti/icons/images/notebook.svg Executable file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><title>notebook</title><path d="M15.5,2V15H.5V2h2V1h3a4.19,4.19,0,0,1,1.32.21A3.87,3.87,0,0,1,8,1.84a3.87,3.87,0,0,1,1.18-.63A4.19,4.19,0,0,1,10.5,1h3V2ZM1.5,14H7.8a4.43,4.43,0,0,0-.51-.43,3.41,3.41,0,0,0-.54-.31,2.74,2.74,0,0,0-.59-.2A3.2,3.2,0,0,0,5.5,13h-3V3h-1Zm2-2h2a4.18,4.18,0,0,1,1,.13,4,4,0,0,1,1,.39V2.72a3,3,0,0,0-.94-.54A3.15,3.15,0,0,0,5.5,2h-2Zm11-9h-1V13h-3a3.2,3.2,0,0,0-.67.07,2.74,2.74,0,0,0-.59.2,3.41,3.41,0,0,0-.54.31A4.43,4.43,0,0,0,8.2,14h6.3Zm-4-1a3.15,3.15,0,0,0-1.06.18,3,3,0,0,0-.94.54v9.8a4,4,0,0,1,1-.39,4.18,4.18,0,0,1,1-.13h2V2Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 661 B

1
extensions/theme-seti/icons/images/notebook_inverse.svg Executable file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.cls-1{fill:#fff;}</style></defs><title>notebook_inverse</title><path class="cls-1" d="M15.46,2V15H.46V2h2V1h3a4.19,4.19,0,0,1,1.32.21A3.87,3.87,0,0,1,8,1.84a3.87,3.87,0,0,1,1.18-.63A4.19,4.19,0,0,1,10.46,1h3V2Zm-14,12h6.3a4.43,4.43,0,0,0-.51-.43,3.41,3.41,0,0,0-.54-.31,2.74,2.74,0,0,0-.59-.2A3.2,3.2,0,0,0,5.46,13h-3V3h-1Zm2-2h2a4.18,4.18,0,0,1,1,.13,4,4,0,0,1,1,.39V2.72a3,3,0,0,0-.94-.54A3.15,3.15,0,0,0,5.46,2h-2Zm11-9h-1V13h-3a3.2,3.2,0,0,0-.67.07,2.74,2.74,0,0,0-.59.2,3.41,3.41,0,0,0-.54.31,4.43,4.43,0,0,0-.51.43h6.3Zm-4-1a3.15,3.15,0,0,0-1.06.18,3,3,0,0,0-.94.54v9.8a4,4,0,0,1,1-.39,4.18,4.18,0,0,1,1-.13h2V2Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 734 B

23
extensions/theme-seti/icons/vs-seti-icon-theme.json
View File

@@ -1240,6 +1240,13 @@
"_zip_1": { "_zip_1": {
"fontCharacter": "\\E091", "fontCharacter": "\\E091",
"fontColor": "#6d8086" "fontColor": "#6d8086"
},
// {{SQL CARBON EDIT}}
"notebook": {
"iconPath": "./images/notebook.svg"
},
"notebook_dark": {
"iconPath": "./images/notebook_inverse.svg"
} }
}, },
"file": "_default", "file": "_default",
@@ -1422,7 +1429,9 @@
"htaccess": "_config", "htaccess": "_config",
"key": "_lock", "key": "_lock",
"cert": "_lock", "cert": "_lock",
"ds_store": "_ignored" "ds_store": "_ignored",
// {{SQL CARBON EDIT}}
"ipynb": "notebook_dark"
}, },
"fileNames": { "fileNames": {
"mix": "_hex", "mix": "_hex",
@@ -1531,7 +1540,9 @@
"haml": "_haml", "haml": "_haml",
"stylus": "_stylus", "stylus": "_stylus",
"vala": "_vala", "vala": "_vala",
"todo": "_todo" "todo": "_todo",
// {{SQL CARBON EDIT}}
"notebook": "notebook_dark"
}, },
"light": { "light": {
"file": "_default_light", "file": "_default_light",
@@ -1714,7 +1725,9 @@
"htaccess": "_config_light", "htaccess": "_config_light",
"key": "_lock_light", "key": "_lock_light",
"cert": "_lock_light", "cert": "_lock_light",
"ds_store": "_ignored_light" "ds_store": "_ignored_light",
// {{SQL CARBON EDIT}}
"ipynb": "notebook"
}, },
"languageIds": { "languageIds": {
"bat": "_windows_light", "bat": "_windows_light",
@@ -1773,7 +1786,9 @@
"elixir": "_elixir_light", "elixir": "_elixir_light",
"haml": "_haml_light", "haml": "_haml_light",
"stylus": "_stylus_light", "stylus": "_stylus_light",
"vala": "_vala_light" "vala": "_vala_light",
// {{SQL CARBON EDIT}}
"notebook": "notebook"
}, },
"fileNames": { "fileNames": {
"mix": "_hex_light", "mix": "_hex_light",