ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-10 10:12:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

'Attach to' with Spark kernel resets to sql connection on cancelling connection dialog (#4024)

Browse Source 
* Sql connection resets to Select Connection on cancelling dialog

* Hiding error message wehen cancel the connection dialog
This commit is contained in:
Raj
2019-02-14 16:39:23 -08:00
committed by GitHub
parent db1f412dae
commit b4d304c21e
4 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/parts/notebook/notebookActions.ts
View File

@@ -392,11 +392,11 @@ export class AttachToDropdown extends SelectBox {
return otherConnections;
}
public doChangeContext(connection?: ConnectionProfile): void {
public doChangeContext(connection?: ConnectionProfile, hideErrorMessage?: boolean): void {
if (this.value === msgAddNewConnection) {
this.openConnectionDialog();
} else {
this.model.changeContext(this.value, connection).then(ok => undefined, err => this._notificationService.error(getErrorMessage(err)));
this.model.changeContext(this.value, connection, hideErrorMessage).then(ok => undefined, err => this._notificationService.error(getErrorMessage(err)));
}
}
@@ -412,6 +412,7 @@ export class AttachToDropdown extends SelectBox {
let attachToConnections = this.values;
if (!connection) {
this.loadAttachToDropdown(this.model, this.getKernelDisplayName());
this.doChangeContext(undefined, true);
return;
}
let connectionProfile = new ConnectionProfile(this._capabilitiesService, connection);