Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)

* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
This commit is contained in:
Aasim Khan
2022-06-03 16:31:03 -07:00
committed by GitHub
parent f0f4a0a3cf
commit b63fd59372
39 changed files with 540 additions and 42 deletions

View File

@@ -90,7 +90,6 @@ export function textFormatter(row: number | undefined, cell: any | undefined, va
let valueToDisplay = '';
let titleValue = '';
let cellStyle = '';
if (DBCellValue.isDBCellValue(value)) {
valueToDisplay = 'NULL';
if (!value.isNull) {

View File

@@ -20,7 +20,8 @@ export class TextWithIconColumn<T extends Slick.SlickData> implements TableColum
resizable: this.options.resizable,
formatter: (row: number, cell: number, value: any, columnDef: Slick.Column<T>, dataContext: T): string => {
const iconValue = getIconCellValue(this.options, dataContext);
return `<div class="icon codicon slick-icon-cell-content ${iconValue.iconCssClass ?? ''}">${escape(iconValue.title ?? '')}</div>`;
const titleValue = escape(iconValue.title ?? '');
return `<div class="icon codicon slick-icon-cell-content ${iconValue.iconCssClass ?? ''}" title="${titleValue}">${titleValue}</div>`;
},
width: this.options.width,
name: this.options.name,