ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-27 17:23:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Miscellaneous UI improvements from feedback (#22592)

Browse Source 
* Hide more info for assessment issues without help links

* Add info box about blob container folders

* WIP - reuse create DMS dialog for IR registration

* Revert "Add info box about blob container folders"

This reverts commit 30b8892ea7918841a6466b59058181062d367ba5.

* Add help link to target platform selection page explaining Azure SQL offerings

* Revert "WIP - reuse create DMS dialog for IR registration"

This reverts commit 5fac6b5c7148b2520cc42ce9fad549cde28baba2.

* Don't show storage account warning banner for DB scenario

* Vbump extension and migration service

* Test - fix http request format from chsuh/fixFormat

* Add instructions for table mapping and schema migration

* Revert "Test - fix http request format from chsuh/fixFormat"

This reverts commit 4992603532e98dff3b7ba6f04ba9304d173fc5ad.
This commit is contained in:
Raymond Truong
2023-04-10 10:20:39 -07:00
committed by GitHub
parent a60d6107b4
commit b6f1b949d7
6 changed files with 89 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
extensions/sql-migration/src/dialog/assessmentResults/sqlDatabasesTree.ts
View File

@@ -69,7 +69,8 @@ export class SqlDatabaseTree {
private _objectDetailsType!: azdata.TextComponent;
private _objectDetailsName!: azdata.TextComponent;
private _objectDetailsSample!: azdata.TextComponent;
private _moreInfo!: azdata.HyperlinkComponent;
private _moreInfoTitle!: azdata.TextComponent;
private _moreInfoText!: azdata.HyperlinkComponent;
private _assessmentTitle!: azdata.TextComponent;
private _databaseTableValues!: azdata.DeclarativeTableCellValue[][];
@@ -626,12 +627,13 @@ export class SqlDatabaseTree {
.withProps({
CSSStyles: textStyle
}).component();
const moreInfo = this._view.modelBuilder.text()
this._moreInfoTitle = this._view.modelBuilder.text()
.withProps({
value: constants.MORE_INFO,
CSSStyles: LABEL_CSS
}).component();
this._moreInfo = this._view.modelBuilder.hyperlink()
this._moreInfoText = this._view.modelBuilder.hyperlink()
.withProps({
label: '',
url: '',
@@ -645,8 +647,8 @@ export class SqlDatabaseTree {
this._descriptionText,
recommendationTitle,
this._recommendationText,
moreInfo,
this._moreInfo])
this._moreInfoTitle,
this._moreInfoText])
.withLayout({ flexFlow: 'column' })
.component();
@@ -811,14 +813,31 @@ export class SqlDatabaseTree {
}
public async refreshAssessmentDetails(selectedIssue?: SqlMigrationAssessmentResultItem): Promise<void> {
this._assessmentTitle.value = selectedIssue?.checkId || '';
this._descriptionText.value = selectedIssue?.description || '';
this._moreInfo.url = selectedIssue?.helpLink || '';
this._moreInfo.label = selectedIssue?.displayName || '';
this._moreInfo.ariaLabel = selectedIssue?.displayName || '';
this._impactedObjects = selectedIssue?.impactedObjects || [];
this._recommendationText.value = selectedIssue?.message || constants.NA;
await this._assessmentTitle.updateProperty('value', selectedIssue?.checkId || '');
await this._descriptionText.updateProperty('value', selectedIssue?.description || '');
await this._recommendationText.updateProperty('value', selectedIssue?.message || constants.NA);
if (selectedIssue?.helpLink) {
await this._moreInfoTitle.updateProperty('display', 'flex');
await this._moreInfoText.updateProperties({
'display': 'flex',
'url': selectedIssue?.helpLink || '',
'label': selectedIssue?.displayName || '',
'ariaLabel': selectedIssue?.displayName || '',
'showLinkIcon': true
});
} else {
await this._moreInfoTitle.updateProperty('display', 'none');
await this._moreInfoText.updateProperties({
'display': 'none',
'url': '',
'label': '',
'ariaLabel': '',
'showLinkIcon': false
});
}
this._impactedObjects = selectedIssue?.impactedObjects || [];
await this._impactedObjectsTable.setDataValues(
this._impactedObjects.map(
(object) => [{ value: object.objectType }, { value: object.name }]));