ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Miscellaneous UI improvements from feedback (#22592)

Browse Source 
* Hide more info for assessment issues without help links

* Add info box about blob container folders

* WIP - reuse create DMS dialog for IR registration

* Revert "Add info box about blob container folders"

This reverts commit 30b8892ea7918841a6466b59058181062d367ba5.

* Add help link to target platform selection page explaining Azure SQL offerings

* Revert "WIP - reuse create DMS dialog for IR registration"

This reverts commit 5fac6b5c7148b2520cc42ce9fad549cde28baba2.

* Don't show storage account warning banner for DB scenario

* Vbump extension and migration service

* Test - fix http request format from chsuh/fixFormat

* Add instructions for table mapping and schema migration

* Revert "Test - fix http request format from chsuh/fixFormat"

This reverts commit 4992603532e98dff3b7ba6f04ba9304d173fc5ad.
This commit is contained in:
Raymond Truong
2023-04-10 10:20:39 -07:00
committed by GitHub
parent a60d6107b4
commit b6f1b949d7
6 changed files with 89 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
extensions/sql-migration/src/wizard/databaseBackupPage.ts
View File

@@ -892,7 +892,8 @@ export class DatabaseBackupPage extends MigrationWizardPage {
: undefined!;
this._sourceHelpText.value = constants.SQL_SOURCE_DETAILS(
this.migrationStateModel._authenticationType,
connectionProfile.serverName);
connectionProfile.serverName,
isSqlDbTarget);
this._sqlSourceUsernameInput.value = username;
this._sqlSourcePassword.value = (await getSourceConnectionCredentials()).password;
@@ -1209,7 +1210,7 @@ export class DatabaseBackupPage extends MigrationWizardPage {
let uniqueBackupLocations = [...new Set(backupLocations)];
if (uniqueBackupLocations.length !== backupLocations.length) {
if (!isSqlDbTarget && uniqueBackupLocations.length !== backupLocations.length) {
this.wizard.message = {
level: azdata.window.MessageLevel.Warning,
text: constants.DATABASE_BACKUP_BLOB_FOLDER_STRUCTURE_WARNING,
@@ -1242,7 +1243,7 @@ export class DatabaseBackupPage extends MigrationWizardPage {
let uniqueBackupLocations = [...new Set(backupLocations)];
if (uniqueBackupLocations.length !== backupLocations.length) {
if (!isSqlDbTarget && uniqueBackupLocations.length !== backupLocations.length) {
this.wizard.message = {
level: azdata.window.MessageLevel.Warning,
text: constants.DATABASE_BACKUP_BLOB_FOLDER_STRUCTURE_WARNING,
@@ -1656,6 +1657,32 @@ export class DatabaseBackupPage extends MigrationWizardPage {
}
private _migrationTableSelectionContainer(): azdata.FlexContainer {
const tableMappingHeader = this._view.modelBuilder.text()
.withProps({
value: constants.DATABASE_TABLE_SELECTION_LABEL,
width: WIZARD_INPUT_COMPONENT_WIDTH,
CSSStyles: { ...styles.SECTION_HEADER_CSS }
}).component();
const tableMappingText = this._view.modelBuilder.text()
.withProps({
value: constants.DATABASE_TABLE_SELECTION_DESCRIPTION,
width: WIZARD_INPUT_COMPONENT_WIDTH,
CSSStyles: { ...styles.BODY_CSS }
}).component();
const tableMappingInfoBox = this._view.modelBuilder.infoBox()
.withProps({
text: constants.DATABASE_SCHEMA_MIGRATION_HELP,
style: 'information',
width: WIZARD_INPUT_COMPONENT_WIDTH,
CSSStyles: { ...styles.BODY_CSS, 'margin': '5px 0 0 0' },
links: [
{ text: constants.DATABASE_SCHEMA_MIGRATION_DACPAC_EXTENSION, url: 'https://learn.microsoft.com/sql/azure-data-studio/extensions/sql-server-dacpac-extension' },
{ text: constants.DATABASE_SCHEMA_MIGRATION_PROJECTS_EXTENSION, url: 'https://learn.microsoft.com/sql/azure-data-studio/extensions/sql-database-project-extension' },
]
}).component();
this._refreshButton = this._view.modelBuilder.button()
.withProps({
buttonType: azdata.ButtonType.Normal,
@@ -1739,6 +1766,9 @@ export class DatabaseBackupPage extends MigrationWizardPage {
return this._view.modelBuilder.flexContainer()
.withItems([
tableMappingHeader,
tableMappingText,
tableMappingInfoBox,
this._refreshLoading,
this._databaseTable])
.withLayout({ flexFlow: 'column' })