ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix some of the issues found in the bug bash (#24348)

Browse Source
This commit is contained in:
Barbara Valdez
2023-09-09 01:36:56 -07:00
committed by GitHub
parent 4a9feedbcc
commit b8629592d4
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts
View File

@@ -597,8 +597,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, dataLocationInputboxProps); }, dataLocationInputboxProps);
const dataLocationButton = this.createBrowseButton(async () => { const dataLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.dataLocation); const newPath = await this.selectFolder(this.objectInfo.dataLocation);
this.dataLocationInput.value = newPath; if (newPath) {
this.objectInfo.dataLocation = newPath; this.dataLocationInput.value = newPath;
this.objectInfo.dataLocation = newPath;
}
if (this.objectInfo.dataLocation !== this.originalObjectInfo.dataLocation) { if (this.objectInfo.dataLocation !== this.originalObjectInfo.dataLocation) {
this.shouldRestartServer = true; this.shouldRestartServer = true;
} }
@@ -613,8 +615,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, logLocationInputboxProps); }, logLocationInputboxProps);
const logLocationButton = this.createBrowseButton(async () => { const logLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.logLocation); const newPath = await this.selectFolder(this.objectInfo.logLocation);
this.logLocationInput.value = newPath; if (newPath) {
this.objectInfo.logLocation = newPath; this.logLocationInput.value = newPath;
this.objectInfo.logLocation = newPath;
}
if (this.objectInfo.logLocation !== this.originalObjectInfo.logLocation) { if (this.objectInfo.logLocation !== this.originalObjectInfo.logLocation) {
this.shouldRestartServer = true; this.shouldRestartServer = true;
} }
@@ -626,8 +630,10 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
}, backupLocationInputboxProps); }, backupLocationInputboxProps);
const backupLocationButton = this.createBrowseButton(async () => { const backupLocationButton = this.createBrowseButton(async () => {
const newPath = await this.selectFolder(this.objectInfo.backupLocation); const newPath = await this.selectFolder(this.objectInfo.backupLocation);
this.backupLocationInput.value = newPath; if (newPath) {
this.objectInfo.backupLocation = newPath; this.backupLocationInput.value = newPath;
this.objectInfo.backupLocation = newPath;
}
}, isEnabled); }, isEnabled);
const backupLocationInputContainer = this.createLabelInputContainer(localizedConstants.backupLocationText, [this.backupLocationInput, backupLocationButton]) const backupLocationInputContainer = this.createLabelInputContainer(localizedConstants.backupLocationText, [this.backupLocationInput, backupLocationButton])
@@ -706,7 +712,7 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
this.fullTextUpgradeOptionDropdown = this.createDropdown(localizedConstants.fullTextUpgradeOptionLabel, async (newValue) => { this.fullTextUpgradeOptionDropdown = this.createDropdown(localizedConstants.fullTextUpgradeOptionLabel, async (newValue) => {
this.objectInfo.fullTextUpgradeOption = newValue; this.objectInfo.fullTextUpgradeOption = newValue;
}, this.viewInfo.fullTextUpgradeOptions, this.objectInfo.fullTextUpgradeOption); }, this.viewInfo.fullTextUpgradeOptions, this.objectInfo.fullTextUpgradeOption, !!this.objectInfo.fullTextUpgradeOption);
const fullTextUpgradeOptionContainer = this.createLabelInputContainer(localizedConstants.fullTextUpgradeOptionLabel, this.fullTextUpgradeOptionDropdown); const fullTextUpgradeOptionContainer = this.createLabelInputContainer(localizedConstants.fullTextUpgradeOptionLabel, this.fullTextUpgradeOptionDropdown);
this.maxTextReplicationSizeInput = this.createInputBox(async (newValue) => { this.maxTextReplicationSizeInput = this.createInputBox(async (newValue) => {