ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

support for connect with connection string (#19355)

Browse Source 
* wip

* WIP

* radio button

* handle connection string

* fix test

* fix test

* fix test cases

* remember password

* pr comments

* pr comments
This commit is contained in:
Alan Ren
2022-05-13 14:48:12 -07:00
committed by GitHub
parent 128767c713
commit b8858f011d
12 changed files with 301 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/workbench/services/connection/browser/connectionDialogService.ts
View File

@@ -49,7 +49,7 @@ export interface IConnectionComponentCallbacks {
export interface IConnectionComponentController {
showUiComponent(container: HTMLElement, didChange?: boolean): void;
initDialog(providers: string[], model: IConnectionProfile): void;
validateConnection(): IConnectionValidateResult;
validateConnection(): Promise<IConnectionValidateResult>;
fillInConnectionInputs(connectionInfo: IConnectionProfile): void;
handleOnConnecting(): void;
handleResetConnection(): void;
@@ -162,14 +162,14 @@ export class ConnectionDialogService implements IConnectionDialogService {
}
private handleOnConnect(params: INewConnectionParams, profile?: IConnectionProfile): void {
private async handleOnConnect(params: INewConnectionParams, profile?: IConnectionProfile): Promise<void> {
this._logService.debug('ConnectionDialogService: onConnect event is received');
if (!this._connecting) {
this._logService.debug('ConnectionDialogService: Start connecting');
this._connecting = true;
this.handleProviderOnConnecting();
if (!profile) {
let result = this.uiController.validateConnection();
let result = await this.uiController.validateConnection();
if (!result.isValid) {
this._logService.debug('ConnectionDialogService: Connection is invalid');
this._connecting = false;
@@ -472,8 +472,8 @@ export class ConnectionDialogService implements IConnectionDialogService {
this._connectionDialog.databaseDropdownExpanded = this.uiController.databaseDropdownExpanded;
this.handleOnCancel(this._connectionDialog.newConnectionParams);
});
this._connectionDialog.onConnect((profile) => {
this.handleOnConnect(this._connectionDialog.newConnectionParams, profile as IConnectionProfile);
this._connectionDialog.onConnect(async (profile) => {
await this.handleOnConnect(this._connectionDialog.newConnectionParams, profile as IConnectionProfile);
});
this._connectionDialog.onShowUiComponent((input) => this.handleShowUiComponent(input));
this._connectionDialog.onInitDialog(() => this.handleInitDialog());