ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Fix strict compile errors (#12591)

Browse Source 
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
This commit is contained in:
Lucy Zhang
2020-10-08 15:39:57 -07:00
committed by GitHub
parent 3e0135b6b3
commit b910bf2f33
16 changed files with 244 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
extensions/integration-tests/src/test/notebook.util.ts
View File

@@ -24,9 +24,9 @@ export const pySparkNotebookContent: azdata.nb.INotebookContents = {
execution_count: 1
}],
metadata: {
'kernelspec': {
'name': 'pysparkkernel',
'display_name': 'PySpark'
kernelspec: {
name: 'pysparkkernel',
display_name: 'PySpark'
}
},
nbformat: 4,
@@ -41,8 +41,9 @@ export const notebookContentForCellLanguageTest: azdata.nb.INotebookContents = {
execution_count: 1
}],
metadata: {
'kernelspec': {
'name': ''
kernelspec: {
name: '',
display_name: ''
},
},
nbformat: 4,
@@ -72,9 +73,9 @@ export const pythonNotebookMultipleCellsContent: azdata.nb.INotebookContents = {
execution_count: 1
}],
metadata: {
'kernelspec': {
'name': 'python3',
'display_name': 'Python 3'
kernelspec: {
name: 'python3',
display_name: 'Python 3'
}
},
nbformat: 4,
@@ -89,9 +90,9 @@ export const sqlNotebookContent: azdata.nb.INotebookContents = {
execution_count: 1
}],
metadata: {
'kernelspec': {
'name': 'SQL',
'display_name': 'SQL'
kernelspec: {
name: 'SQL',
display_name: 'SQL'
}
},
nbformat: 4,
@@ -116,9 +117,9 @@ export const sqlNotebookMultipleCellsContent: azdata.nb.INotebookContents = {
execution_count: 1
}],
metadata: {
'kernelspec': {
'name': 'SQL',
'display_name': 'SQL'
kernelspec: {
name: 'SQL',
display_name: 'SQL'
}
},
nbformat: 4,
@@ -126,9 +127,9 @@ export const sqlNotebookMultipleCellsContent: azdata.nb.INotebookContents = {
};
export const pySparkKernelMetadata = {
'kernelspec': {
'name': 'pysparkkernel',
'display_name': 'PySpark'
kernelspec: {
name: 'pysparkkernel',
display_name: 'PySpark'
}
};
@@ -138,9 +139,9 @@ export const pySparkKernelSpec = {
};
export const sqlKernelMetadata = {
'kernelspec': {
'name': 'SQL',
'display_name': 'SQL'
kernelspec: {
name: 'SQL',
display_name: 'SQL'
}
};
@@ -150,9 +151,9 @@ export const sqlKernelSpec: azdata.nb.IKernelSpec = {
};
export const pythonKernelMetadata = {
'kernelspec': {
'name': 'python3',
'display_name': 'Python 3'
kernelspec: {
name: 'python3',
display_name: 'Python 3'
}
};

3
extensions/notebook/src/test/model/sessionManager.test.ts
View File

@@ -186,7 +186,8 @@ describe('Jupyter Session', function (): void {
// When I call changeKernel on the wrapper
let kernel = await session.changeKernel({
name: 'python'
name: 'python',
display_name: 'Python'
});
// Then I expect it to have the ID, and only be called once
should(kernel.id).equal('id');