ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Fix strict compile errors (#12591)

Browse Source 
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
This commit is contained in:
Lucy Zhang
2020-10-08 15:39:57 -07:00
committed by GitHub
parent 3e0135b6b3
commit b910bf2f33
16 changed files with 244 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/sql/azdata.d.ts vendored
View File

@@ -4653,11 +4653,14 @@ declare module 'azdata' {
}
export interface INotebookMetadata {
kernelspec: IKernelInfo;
kernelspec?: IKernelInfo | IKernelSpec;
language_info?: ILanguageInfo;
tags?: string[];
}
/**
* @deprecated Use IKernelSpec instead
*/
export interface IKernelInfo {
name: string;
language?: string;
@@ -5059,8 +5062,8 @@ declare module 'azdata' {
* An arguments object for the kernel changed event.
*/
export interface IKernelChangedArgs {
oldValue: IKernel | null;
newValue: IKernel | null;
oldValue: IKernel | undefined;
newValue: IKernel | undefined;
}
/// -------- JSON objects, and objects primarily intended not to have methods -----------
@@ -5088,7 +5091,7 @@ declare module 'azdata' {
/**
* The original outgoing message.
*/
readonly msg: IMessage;
readonly msg: IMessage | undefined;
/**
* A Thenable that resolves when the future is done.
@@ -5183,7 +5186,7 @@ declare module 'azdata' {
*/
export interface IExecuteReply {
status: 'ok' | 'error' | 'abort';
execution_count: number | null;
execution_count: number | null | undefined;
}
/**
@@ -5199,11 +5202,11 @@ declare module 'azdata' {
* **See also:** [[IMessage]]
*/
export interface IHeader {
username: string;
version: string;
session: string;
msg_id: string;
msg_type: string;
username?: string;
version?: string;
session?: string;
msg_id?: string;
}
/**
@@ -5211,10 +5214,10 @@ declare module 'azdata' {
*/
export interface IMessage {
type: Channel;
header: IHeader;
parent_header: IHeader | {};
metadata: {};
content: any;
header?: IHeader;
parent_header?: IHeader | {};
metadata?: {};
}
/**