Notebooks: Fix strict compile errors (#12591)

* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check

src/sql/workbench/contrib/notebook/test/browser/cellToolbarActions.test.ts

@@ -188,7 +188,8 @@ export async function createandLoadNotebookModel(codeContent?: nb.INotebookConte
 		metadata: {
 			kernelspec: {
 				name: 'python',
-				language: 'python'
+				language: 'python',
+				display_name: 'Python 3'
 			}
 		},
 		nbformat: 4,

src/sql/workbench/contrib/notebook/test/electron-browser/clientSession.test.ts

@@ -49,7 +49,7 @@ suite('Client Session', function (): void {
 		assert(!session.isReady);
 		assert.equal(session.status, 'starting');
 		assert(!session.isInErrorState);
-		assert(isUndefinedOrNull(session.errorMessage));
+		assert.equal(session.errorMessage, '');
 	});
 
 	test('Should call on serverManager startup if set', async function (): Promise<void> {

src/sql/workbench/contrib/notebook/test/electron-browser/contentManagers.test.ts

@@ -27,7 +27,8 @@ let expectedNotebookContent: nb.INotebookContents = {
 	metadata: {
 		kernelspec: {
 			name: 'mssql',
-			language: 'sql'
+			language: 'sql',
+			display_name: 'SQL'
 		}
 	},
 	nbformat: 4,
@@ -117,7 +118,8 @@ suite('Local Content Manager', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'mssql',
-					language: 'sql'
+					language: 'sql',
+					display_name: 'SQL'
 				}
 			},
 			nbformat: 4,
@@ -158,7 +160,8 @@ suite('Local Content Manager', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'mssql',
-					language: 'sql'
+					language: 'sql',
+					display_name: 'SQL'
 				}
 			},
 			nbformat: 4,
@@ -191,7 +194,8 @@ suite('Local Content Manager', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'Python 3',
-					language: 'python3'
+					language: 'python3',
+					display_name: 'Python 3'
 				}
 			},
 			nbformat: 4,

src/sql/workbench/contrib/notebook/test/electron-browser/notebookFindModel.test.ts

@@ -46,7 +46,8 @@ let expectedNotebookContent: nb.INotebookContents = {
 	metadata: {
 		kernelspec: {
 			name: 'mssql',
-			language: 'sql'
+			language: 'sql',
+			display_name: 'SQL'
 		}
 	},
 	nbformat: 4,
@@ -184,7 +185,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'mssql',
-					language: 'sql'
+					language: 'sql',
+					display_name: 'SQL'
 				}
 			},
 			nbformat: 4,
@@ -216,7 +218,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'python',
-					language: 'python'
+					language: 'python',
+					display_name: 'Python'
 				}
 			},
 			nbformat: 4,
@@ -241,7 +244,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'python',
-					language: 'python'
+					language: 'python',
+					display_name: 'Python'
 				}
 			},
 			nbformat: 4,
@@ -301,7 +305,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'python',
-					language: 'python'
+					language: 'python',
+					display_name: 'Python'
 				}
 			},
 			nbformat: 4,
@@ -333,7 +338,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'python',
-					language: 'python'
+					language: 'python',
+					display_name: 'Python'
 				}
 			},
 			nbformat: 4,
@@ -364,7 +370,8 @@ suite('Notebook Find Model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'mssql',
-					language: 'sql'
+					language: 'sql',
+					display_name: 'SQL'
 				}
 			},
 			nbformat: 4,

src/sql/workbench/contrib/notebook/test/electron-browser/notebookModel.test.ts

@@ -52,7 +52,8 @@ let expectedNotebookContent: nb.INotebookContents = {
 	metadata: {
 		kernelspec: {
 			name: 'mssql',
-			language: 'sql'
+			language: 'sql',
+			display_name: 'SQL'
 		}
 	},
 	nbformat: 4,
@@ -69,7 +70,8 @@ let expectedNotebookContentOneCell: nb.INotebookContents = {
 	metadata: {
 		kernelspec: {
 			name: 'mssql',
-			language: 'sql'
+			language: 'sql',
+			display_name: 'SQL'
 		}
 	},
 	nbformat: 4,
@@ -140,7 +142,8 @@ suite('notebook model', function (): void {
 			metadata: {
 				kernelspec: {
 					name: 'mssql',
-					language: 'sql'
+					language: 'sql',
+					display_name: 'SQL'
 				}
 			},
 			nbformat: 4,

src/sql/workbench/contrib/notebook/test/stubs.ts

@@ -52,7 +52,7 @@ export class NotebookModelStub implements INotebookModel {
 	get kernelChanged(): vsEvent.Event<nb.IKernelChangedArgs> {
 		throw new Error('method not implemented.');
 	}
-	get kernelsChanged(): vsEvent.Event<nb.IKernelSpec> {
+	get kernelsChanged(): vsEvent.Event<nb.IKernel> {
 		throw new Error('method not implemented.');
 	}
 	get layoutChanged(): vsEvent.Event<void> {