ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-12 02:58:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bug bash fixes to Azure Arc PostgreSQL (#20568)

Browse Source 
* Added username field to PG and removed defaultvalue for port

* Disabled system username for miaa. Added username to pg create notebook.

* Block system for pg username

* Remove sql username from pg create

* Add service type

* bump version for preview

* Add dev use label

* Changed postgres icon

* Fixed PG create page not displaying. Wrong type

* Fixed service type

* changed naming for admin usernames sql and pg

* sql and pg dev use fix

* Move port under service type and make storage class not required

* Fixed regex to include things like sa1 system1

* Made storage class params optional

* Added placeholder text and changed PG admin username label

* Remove backups

* Removed postgres hardcoded username in connectionstring

* Remove more postgres username hardcoded

Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2022-09-09 11:49:27 -07:00
committed by GitHub
parent a6920ca601
commit b9cb3de85b
7 changed files with 89 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/arc/notebooks/arcDeployment/deploy.postgres.existing.arc.ipynb
View File

@@ -99,16 +99,22 @@
"print (f'Creating the PostgreSQL server - Azure Arc instance')\n",
"\n",
"port = f' --port \"{postgres_server_port}\"' if postgres_server_port else \"\"\n",
"service_type = f' --service-type \"{postgres_server_service_type}\"' if postgres_server_service_type else \"\"\n",
"volume_size_data = f' --volume-size-data {postgres_server_volume_size_data}Gi' if postgres_server_volume_size_data else \"\"\n",
"volume_size_logs = f' --volume-size-logs {postgres_server_volume_size_logs}Gi' if postgres_server_volume_size_logs else \"\"\n",
"\n",
"storage_class_data = f' --storage-class-data {postgres_storage_class_data}' if postgres_storage_class_data else \"\"\n",
"storage_class_logs = f' --storage-class-logs {postgres_storage_class_logs}' if postgres_storage_class_logs else \"\"\n",
"\n",
"cores_request = f' --cores-request {postgres_server_cores_request}' if postgres_server_cores_request else \"\"\n",
"cores_limit = f' --cores-limit {postgres_server_cores_limit}' if postgres_server_cores_limit else \"\"\n",
"memory_request = f' --memory-request {postgres_server_memory_request}Gi' if postgres_server_memory_request else \"\"\n",
"memory_limit = f' --memory-limit {postgres_server_memory_limit}Gi' if postgres_server_memory_limit else \"\"\n",
"dev_use = ' --dev' if postgres_server_dev_use == 'true' else ''\n",
"\n",
"os.environ[\"AZDATA_USERNAME\"] = postgres_server_username\n",
"os.environ[\"AZDATA_PASSWORD\"] = os.environ[\"AZDATA_NB_VAR_POSTGRES_SERVER_PASSWORD\"]\n",
"cmd = f'az postgres server-arc create --name {postgres_server_name} --k8s-namespace {arc_data_controller_namespace} --use-k8s --storage-class-data {postgres_storage_class_data} --storage-class-logs {postgres_storage_class_logs}{port}{volume_size_data}{volume_size_logs}{cores_request}{cores_limit}{memory_request}{memory_limit}'\n",
"cmd = f'az postgres server-arc create --name {postgres_server_name} --k8s-namespace {arc_data_controller_namespace} --use-k8s {storage_class_data}{storage_class_logs}{port}{service_type}{volume_size_data}{volume_size_logs}{cores_request}{cores_limit}{memory_request}{memory_limit}{dev_use}'\n",
"out=run_command()"
]
}