ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-06 17:23:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bug bash fixes to Azure Arc PostgreSQL (#20568)

Browse Source 
* Added username field to PG and removed defaultvalue for port

* Disabled system username for miaa. Added username to pg create notebook.

* Block system for pg username

* Remove sql username from pg create

* Add service type

* bump version for preview

* Add dev use label

* Changed postgres icon

* Fixed PG create page not displaying. Wrong type

* Fixed service type

* changed naming for admin usernames sql and pg

* sql and pg dev use fix

* Move port under service type and make storage class not required

* Fixed regex to include things like sa1 system1

* Made storage class params optional

* Added placeholder text and changed PG admin username label

* Remove backups

* Removed postgres hardcoded username in connectionstring

* Remove more postgres username hardcoded

Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2022-09-09 11:49:27 -07:00
committed by GitHub
parent a6920ca601
commit b9cb3de85b
7 changed files with 89 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/arc/notebooks/arcDeployment/deploy.sql.existing.arc.ipynb
View File

@@ -129,7 +129,7 @@
"\n",
"service_tier = f' --tier {sql_service_tier}'\n",
"cores_limit = f' --cores-limit {sql_cores_limit}'\n",
"dev_use = ' --dev' if sql_dev_use else ''\n",
"dev_use = ' --dev' if sql_dev_use == 'true' else ''\n",
"license_type = ' --license-type BasePrice' if sql_license_type else ' --license-type LicenseIncluded'\n",
"\n",
"os.environ[\"AZDATA_USERNAME\"] = sql_username\n",