ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bug bash fixes to Azure Arc PostgreSQL (#20568)

Browse Source 
* Added username field to PG and removed defaultvalue for port

* Disabled system username for miaa. Added username to pg create notebook.

* Block system for pg username

* Remove sql username from pg create

* Add service type

* bump version for preview

* Add dev use label

* Changed postgres icon

* Fixed PG create page not displaying. Wrong type

* Fixed service type

* changed naming for admin usernames sql and pg

* sql and pg dev use fix

* Move port under service type and make storage class not required

* Fixed regex to include things like sa1 system1

* Made storage class params optional

* Added placeholder text and changed PG admin username label

* Remove backups

* Removed postgres hardcoded username in connectionstring

* Remove more postgres username hardcoded

Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2022-09-09 11:49:27 -07:00
committed by GitHub
parent a6920ca601
commit b9cb3de85b
7 changed files with 89 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
extensions/arc/package.json
View File

@@ -2,7 +2,7 @@
"name": "arc",
"displayName": "%arc.displayName%",
"description": "%arc.description%",
"version": "1.5.2",
"version": "1.5.3",
"publisher": "Microsoft",
"license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/main/LICENSE.txt",
"icon": "images/extension.png",
@@ -758,7 +758,8 @@
"regex": "^[a-z]([-a-z0-9]{0,11}[a-z0-9])?$",
"description": "%arc.sql.invalid.instance.name%"
}
]
],
"placeHolder": "%arc.sql.instance.name.placeholder%"
},
{
"label": "%arc.sql.username%",
@@ -768,10 +769,11 @@
"validations": [
{
"type": "regex_match",
"regex": "^(?!sa$)",
"regex": "^(?!system$|sa$).*$",
"description": "%arc.sql.invalid.username%"
}
]
],
"placeHolder": "%arc.sql.username.placeholder%"
},
{
"label": "%arc.password%",
@@ -1378,7 +1380,24 @@
"description": "%arc.postgres.server.name.validation.description%"
}
],
"required": true
"required": true,
"placeHolder": "%arc.postgres.server.name.placeholder%"
},
{
"label": "%arc.postgres.server.username%",
"variableName": "AZDATA_NB_VAR_POSTGRES_SERVER_USERNAME",
"type": "text",
"required": true,
"validations": [
{
"type": "regex_match",
"regex": "^(?!system$).*$",
"description": "%arc.postgres.server.invalid.username%"
}
],
"defaultValue": "",
"enabled": true,
"placeHolder": "%arc.postgres.server.username.placeholder%"
},
{
"label": "%arc.password%",
@@ -1389,6 +1408,17 @@
"defaultValue": "",
"required": true
},
{
"label": "%arc.postgres.server.service.type%",
"variableName": "AZDATA_NB_VAR_POSTGRES_SERVER_SERVICE_TYPE",
"type": "options",
"required": true,
"options": {
"values": ["NodePort", "LoadBalancer"],
"defaultValue": "NodePort",
"optionsType": "radio"
}
},
{
"label": "%arc.postgres.server.port%",
"variableName": "AZDATA_NB_VAR_POSTGRES_SERVER_PORT",
@@ -1399,9 +1429,15 @@
"description": "%should.be.integer%"
}
],
"defaultValue": "5432",
"min": 1,
"max": 65535
},
{
"type": "checkbox",
"label": "%arc.postgres.server.dev.use.label%",
"variableName": "AZDATA_NB_VAR_POSTGRES_SERVER_DEV_USE",
"description": "%arc.postgres.server.dev.use.description%",
"defaultValue": false
}
]
},
@@ -1473,8 +1509,7 @@
"label": "%arc.storage-class.data.label%",
"description": "%arc.postgres.storage-class.data.description%",
"variableName": "AZDATA_NB_VAR_POSTGRES_STORAGE_CLASS_DATA",
"type": "kube_storage_class",
"required": true
"type": "kube_storage_class"
},
{
"label": "%arc.postgres.server.volume.size.data.label%",
@@ -1488,8 +1523,7 @@
"label": "%arc.storage-class.logs.label%",
"description": "%arc.postgres.storage-class.logs.description%",
"variableName": "AZDATA_NB_VAR_POSTGRES_STORAGE_CLASS_LOGS",
"type": "kube_storage_class",
"required": true
"type": "kube_storage_class"
},
{
"label": "%arc.postgres.server.volume.size.logs.label%",
@@ -1498,21 +1532,6 @@
"type": "number",
"defaultValue": "5",
"min": 1
},
{
"label": "%arc.storage-class.backups.label%",
"description": "%arc.postgres.storage-class.backups.description%",
"variableName": "AZDATA_NB_VAR_POSTGRES_STORAGE_CLASS_BACKUPS",
"type": "kube_storage_class",
"required": true
},
{
"label": "%arc.postgres.server.volume.size.backups.label%",
"description": "%arc.postgres.server.volume.size.backups.description%",
"variableName": "AZDATA_NB_VAR_POSTGRES_SERVER_VOLUME_SIZE_BACKUPS",
"type": "number",
"defaultValue": "5",
"min": 1
}
]
}