From ba20cdb8853a4028de56ad6152ce4cd1f97e48eb Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Mon, 12 Jul 2021 10:08:59 -0700 Subject: [PATCH] Add accessibility information for MIAA deployment link (#16064) * Add accessibility information for MIAA deployment link * optional --- extensions/arc/package.json | 3 +++ extensions/arc/package.nls.json | 3 ++- src/sql/azdata.proposed.d.ts | 9 +++++++++ .../workbench/browser/modelComponents/text.component.ts | 7 +++++++ 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/extensions/arc/package.json b/extensions/arc/package.json index 7c7219ba71..e7fb23a2e8 100644 --- a/extensions/arc/package.json +++ b/extensions/arc/package.json @@ -1092,6 +1092,9 @@ "links": [ { "text": "%arc.agreement.sql.help.text.learn.more%", + "accessibilityInformation": { + "label": "%arc.agreement.sql.help.text.learn.more.ariaLabel%" + }, "url": "https://go.microsoft.com/fwlink/?linkid=2141849" } ], diff --git a/extensions/arc/package.nls.json b/extensions/arc/package.nls.json index dda62decce..fdadb5c23e 100644 --- a/extensions/arc/package.nls.json +++ b/extensions/arc/package.nls.json @@ -154,5 +154,6 @@ "requested.memory.less.than.or.equal.to.memory.limit": "Requested memory must be less than or equal to memory limit", "memory.limit.greater.than.or.equal.to.requested.memory": "Memory limit must be greater than or equal to requested memory", "arc.agreement.sql.help.text": "Azure Arc enabled Managed Instance provides SQL Server access and feature compatibility that can be deployed on the infrastructure of your choice. While this service is in preview, it has some feature limitations compared to SQL Managed Instance on Azure. {0}", - "arc.agreement.sql.help.text.learn.more": "Learn more" + "arc.agreement.sql.help.text.learn.more": "Learn more", + "arc.agreement.sql.help.text.learn.more.ariaLabel": "Learn more about Azure Arc enabled Managed Instance" } diff --git a/src/sql/azdata.proposed.d.ts b/src/sql/azdata.proposed.d.ts index 8ae844720e..567e5ac416 100644 --- a/src/sql/azdata.proposed.d.ts +++ b/src/sql/azdata.proposed.d.ts @@ -887,6 +887,15 @@ declare module 'azdata' { appendData(data: any[][]): Thenable; } + export interface LinkArea { + /* + * Accessibility information used when screen reader interacts with this link. + * Generally, a link has no need to set the `role` of the accessibilityInformation; + * but it is exposed for situations that may require it. + */ + accessibilityInformation?: vscode.AccessibilityInformation + } + export interface IconColumnCellValue { /** * The icon to be displayed. diff --git a/src/sql/workbench/browser/modelComponents/text.component.ts b/src/sql/workbench/browser/modelComponents/text.component.ts index b739d72f4d..ca42069a68 100644 --- a/src/sql/workbench/browser/modelComponents/text.component.ts +++ b/src/sql/workbench/browser/modelComponents/text.component.ts @@ -124,6 +124,13 @@ export default class TextComponent extends TitledComponentthis.textContainer.nativeElement).appendChild(linkElement.el);