ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix hyperlink in infoBox not following theming (#24488)

Browse Source
This commit is contained in:
Kim Santiago
2023-09-21 14:19:48 -07:00
committed by GitHub
parent 64337310ae
commit ba3d16b63b
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sql/workbench/browser/ui/infoBox/infoBox.ts
View File

@@ -15,6 +15,8 @@ import { KeyCode } from 'vs/base/common/keyCodes';
import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IOpenerService } from 'vs/platform/opener/common/opener';
import { ILogService } from 'vs/platform/log/common/log'; import { ILogService } from 'vs/platform/log/common/log';
import { ThemeIcon } from 'vs/base/common/themables'; import { ThemeIcon } from 'vs/base/common/themables';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { Link } from 'vs/platform/opener/browser/link';
export interface IInfoBoxStyles { export interface IInfoBoxStyles {
informationBackground: string | undefined; informationBackground: string | undefined;
@@ -59,7 +61,8 @@ export class InfoBox extends Disposable {
private readonly _styles: IInfoBoxStyles, private readonly _styles: IInfoBoxStyles,
options: InfoBoxOptions | undefined, options: InfoBoxOptions | undefined,
@IOpenerService private _openerService: IOpenerService, @IOpenerService private _openerService: IOpenerService,
@ILogService private _logService: ILogService @ILogService private _logService: ILogService,
@IInstantiationService private instantiationService: IInstantiationService,
) { ) {
super(); super();
this._infoBoxElement = document.createElement('div'); this._infoBoxElement = document.createElement('div');
@@ -155,11 +158,11 @@ export class InfoBox extends Disposable {
* If the url is empty, electron displays the link as visited. * If the url is empty, electron displays the link as visited.
* TODO: Investigate why it happens and fix the issue iin electron/vsbase. * TODO: Investigate why it happens and fix the issue iin electron/vsbase.
*/ */
const linkElement = DOM.$('a', { const linkElement = this._register(this.instantiationService.createInstance(Link,
this._textElement, {
label: link.text,
href: link.url === '' ? ' ' : link.url href: link.url === '' ? ' ' : link.url
}); }, undefined)).el;
linkElement.innerText = link.text;
if (link.accessibilityInformation) { if (link.accessibilityInformation) {
linkElement.setAttribute('aria-label', link.accessibilityInformation.label); linkElement.setAttribute('aria-label', link.accessibilityInformation.label);