Remove azdata eula acceptance from arc deployments (#12292)

* saving to switch tasks

* activate to exports in extApi

* working version - cleanup pending

* improve messages

* apply pr feedback from a different review

* remove unneeded strings

* redo apiService

* remove async from getVersionFromOutput

* remove _ prefix from protected fields

* error message fix

* throw specif errors from azdata extension

* arrow methods to regular methods

* pr feedback

* expand azdata extension api

* pr feedback

* remove unused var

* pr feedback
This commit is contained in:
Arvind Ranasaria
2020-09-17 11:20:32 -07:00
committed by GitHub
parent 945e04ed92
commit ba44a2f02e
17 changed files with 181 additions and 114 deletions

View File

@@ -4,6 +4,8 @@
*--------------------------------------------------------------------------------------------*/
declare module 'azdata-ext' {
import { SemVer } from 'semver';
/**
* Covers defining what the azdata extension exports to other extensions
*
@@ -80,7 +82,7 @@ declare module 'azdata-ext' {
location: string, // "eastus2euap",
resourceGroup: string, // "my-rg",
subscription: string, // "a5082b29-8c6e-4bc5-8ddd-8ef39dfebc39"
},
},
controller: {
'enableBilling': string, // "True"
'logs.rotation.days': string, // "7"
@@ -254,12 +256,20 @@ declare module 'azdata-ext' {
show(name: string): Promise<AzdataOutput<SqlMiShowResult>>
}
}
}
},
getPath(): string,
login(endpoint: string, username: string, password: string): Promise<AzdataOutput<any>>,
/**
* The semVersion corresponding to this installation of azdata. version() method should have been run
* before fetching this value to ensure that correct value is returned. This is almost always correct unless
* Azdata has gotten reinstalled in the background after this IAzdataApi object was constructed.
*/
getSemVersion(): SemVer,
version(): Promise<AzdataOutput<string>>
}
export interface IExtension {
azdata: IAzdataApi;
isEulaAccepted(): boolean;
}
}