From bae573453ac9b2b7ee7dfa39a8f0d78b4cbb0077 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Mon, 1 Jul 2019 13:46:06 -0700 Subject: [PATCH] Accessibility: Screen Reader Thinks SelectBox is a Button on Mac (#6216) * Stop reading dropdowns as buttons for mac * Remove role of combobox for sql selectbox --- src/sql/base/browser/ui/selectBox/selectBox.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sql/base/browser/ui/selectBox/selectBox.ts b/src/sql/base/browser/ui/selectBox/selectBox.ts index 6c609eb8c7..9a637af19a 100644 --- a/src/sql/base/browser/ui/selectBox/selectBox.ts +++ b/src/sql/base/browser/ui/selectBox/selectBox.ts @@ -83,9 +83,6 @@ export class SelectBox extends vsSelectBox { this.element = dom.append(container, $('.monaco-selectbox.idle')); } - // explicitly set the accessible role so that the screen readers can read the control type properly - this.selectElement.setAttribute('role', 'combobox'); - this._selectBoxOptions = selectBoxOptions; let focusTracker = dom.trackFocus(this.selectElement); this._register(focusTracker);