ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reverted placeholder value reversal (#20294)

Browse Source 
Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2022-08-10 13:08:03 -07:00
committed by GitHub
parent 315e49b2ed
commit bb8c02a01b
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/arc/src/ui/dashboards/miaa/miaaComputeAndStoragePage.ts
View File

@@ -324,7 +324,7 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
} }
private handleOnTextChanged(component: azdata.InputBoxComponent): boolean { private handleOnTextChanged(component: azdata.InputBoxComponent): boolean {
if ((!component.placeHolder)) { if ((!component.value)) {
// if there is no text found in the inputbox component return false // if there is no text found in the inputbox component return false
return false; return false;
} else if ((!component.valid)) { } else if ((!component.valid)) {
@@ -361,8 +361,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
currentCPUSize = ''; currentCPUSize = '';
} }
this.coresLimitBox!.value = currentCPUSize; this.coresLimitBox!.placeHolder = currentCPUSize;
this.coresLimitBox!.placeHolder = ''; this.coresLimitBox!.value = '';
this.saveArgs.coresLimit = undefined; this.saveArgs.coresLimit = undefined;
} }
@@ -377,8 +377,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
currentMemSizeConversion = convertToGibibyteString(currentMemorySize); currentMemSizeConversion = convertToGibibyteString(currentMemorySize);
} }
this.memoryRequestBox!.value = currentMemSizeConversion!; this.memoryRequestBox!.placeHolder = currentMemSizeConversion!;
this.memoryRequestBox!.placeHolder = ''; this.memoryRequestBox!.value = '';
this.saveArgs.memoryRequest = undefined; this.saveArgs.memoryRequest = undefined;
@@ -390,8 +390,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
currentMemSizeConversion = convertToGibibyteString(currentMemorySize); currentMemSizeConversion = convertToGibibyteString(currentMemorySize);
} }
this.memoryLimitBox!.value = currentMemSizeConversion!; this.memoryLimitBox!.placeHolder = currentMemSizeConversion!;
this.memoryLimitBox!.placeHolder = ''; this.memoryLimitBox!.value = '';
this.saveArgs.memoryLimit = undefined; this.saveArgs.memoryLimit = undefined;
@@ -400,8 +400,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
private editSyncSecondaryToCommit(): void { private editSyncSecondaryToCommit(): void {
let currentSyncSecondaryToCommit = this._miaaModel.config?.spec?.syncSecondaryToCommit; let currentSyncSecondaryToCommit = this._miaaModel.config?.spec?.syncSecondaryToCommit;
this.syncSecondaryToCommitBox!.value = currentSyncSecondaryToCommit!; this.syncSecondaryToCommitBox!.placeHolder = currentSyncSecondaryToCommit!;
this.syncSecondaryToCommitBox!.placeHolder = ''; this.syncSecondaryToCommitBox!.value = '';
this.saveArgs.syncSecondaryToCommit = undefined; this.saveArgs.syncSecondaryToCommit = undefined;
} }