Improve Cleanup of Jupyter processes on Notebook and/or ADS Close (#5142)

* Close jupyter and python

* Ensure we stop jupyter correctly on process end

* dont stopServer from clientSession shutdown

* PR comments

* close notebook after each test
This commit is contained in:
Chris LaFreniere
2019-04-26 15:28:26 -07:00
committed by GitHub
parent 91b946bf3d
commit bb9c85cd8f
6 changed files with 21 additions and 16 deletions

View File

@@ -50,7 +50,7 @@ export class ExtHostNotebook implements ExtHostNotebookShape {
let manager = this.findManagerForUri(uriString);
if (manager) {
manager.provider.handleNotebookClosed(uri);
// Note: deliberately not removing handle.
this._adapters.delete(manager.handle);
}
}
@@ -249,7 +249,6 @@ export class ExtHostNotebook implements ExtHostNotebookShape {
private _createDisposable(handle: number): Disposable {
return new Disposable(() => {
this._adapters.delete(handle);
this._proxy.$unregisterNotebookProvider(handle);
});
}