ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-25 17:23:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve Cleanup of Jupyter processes on Notebook and/or ADS Close (#5142)

Browse Source 
* Close jupyter and python

* Ensure we stop jupyter correctly on process end

* dont stopServer from clientSession shutdown

* PR comments

* close notebook after each test
This commit is contained in:
Chris LaFreniere
2019-04-26 15:28:26 -07:00
committed by GitHub
parent 91b946bf3d
commit bb9c85cd8f
6 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/parts/notebook/models/notebookModel.ts
View File

@@ -777,7 +777,7 @@ export class NotebookModel extends Disposable implements INotebookModel {
}
await this.shutdownActiveSession();
} catch (err) {
this.notifyError(localize('shutdownError', "An error occurred when closing the notebook: {0}", notebookUtils.getErrorMessage(err)));
console.log('An error occurred when closing the notebook: {0}', notebookUtils.getErrorMessage(err));
}
}