ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-03-25 14:20:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve Cleanup of Jupyter processes on Notebook and/or ADS Close (#5142)

Browse Source 
* Close jupyter and python

* Ensure we stop jupyter correctly on process end

* dont stopServer from clientSession shutdown

* PR comments

* close notebook after each test
This commit is contained in:
Chris LaFreniere
2019-04-26 15:28:26 -07:00
committed by GitHub
parent 91b946bf3d
commit bb9c85cd8f
6 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sqltest/workbench/api/exthostNotebook.test.ts
View File

@@ -111,10 +111,10 @@ suite('ExtHostNotebook Tests', () => {
});
test('Should call unregister on disposing', () => {
test('Should not call unregister on disposing', () => {
let disposable = extHostNotebook.registerNotebookProvider(notebookProviderMock.object);
disposable.dispose();
mockProxy.verify(p => p.$unregisterNotebookProvider(TypeMoq.It.isValue(savedHandle)), TypeMoq.Times.once());
mockProxy.verify(p => p.$unregisterNotebookProvider(TypeMoq.It.isValue(savedHandle)), TypeMoq.Times.never());
});
});
});