From bc515e8f45f204fd839e5c53ff1e4dfbc57b2bf3 Mon Sep 17 00:00:00 2001
From: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Date: Fri, 30 Jun 2023 14:15:09 -0700
Subject: [PATCH] Fix continuous loop on Cancel (#23609)

---
 .../contrib/commandLine/electron-browser/commandLine.ts        | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts b/src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts
index 39fac595fd..af8ee06bc7 100644
--- a/src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts
+++ b/src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts
@@ -222,7 +222,8 @@ export class CommandLineWorkbenchContribution implements IWorkbenchContribution,
 			}
 			let isOpenOk = await this.confirmConnect(args);
 			if (!isOpenOk) {
-				return false;
+				// returning true will ensure the request won't be looped (since urlService opens url with shouldStop = false)
+				return true;
 			}
 
 			const connectionProfile = this.readProfileFromArgs(args);