ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-25 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Fix Cancel for Connection Dialog to Actually Close Window (#8626)

Browse Source 
* Fix connection dialog not going away on cancel

* Remove unnecessary change
This commit is contained in:
Chris LaFreniere
2019-12-10 16:59:15 -08:00
committed by GitHub
parent 36fd618ed4
commit bceb766d28
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/workbench/contrib/notebook/browser/notebookActions.ts
View File

@@ -364,8 +364,10 @@ export class AttachToDropdown extends SelectBox {
let attachToConnections = this.values;
if (!connection) {
this.loadAttachToDropdown(this.model, this.getKernelDisplayName());
this.doChangeContext(undefined, true);
// If there is no connection, we should choose the previous connection,
// which will always be the first item in the list. Either "Select Connection"
// or a real connection name
this.select(0);
return false;
}
let connectionUri = this._connectionManagementService.getConnectionUri(connection);