From bd4ebe65cce187ea9316bce6fbd0158a99ba6196 Mon Sep 17 00:00:00 2001 From: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com> Date: Tue, 4 May 2021 14:12:53 -0700 Subject: [PATCH] Reverting a change to ensure immediate notebook fix (#15326) --- src/sql/base/browser/ui/selectBox/selectBox.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/sql/base/browser/ui/selectBox/selectBox.ts b/src/sql/base/browser/ui/selectBox/selectBox.ts index 7c1b0519c1..9d5cebab61 100644 --- a/src/sql/base/browser/ui/selectBox/selectBox.ts +++ b/src/sql/base/browser/ui/selectBox/selectBox.ts @@ -216,12 +216,6 @@ export class SelectBox extends vsSelectBox { let selectOptions: SelectOptionItemSQL[] = SelectBox.createOptions(options); this.populateOptionsDictionary(selectOptions); super.setOptions(selectOptions, selected); - // Calling super.setOptions even with a value selected doesn't fire the onSelected event and doesn't update this._selectedOption, - // So manually updating it here to ensure that the value is kept in sync. - // Currently we're not firing the onDidSelect event in this case to align with the base implementation, but that can change if there's a need for that to happen - if (this._dialogOptions !== undefined) { - this._selectedOption = this._dialogOptions[selected]?.value; - } } public get value(): string {