ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix errors throw when doing validity checks (#11171)

Browse Source
This commit is contained in:
Charles Gagnon
2020-07-01 14:37:28 -07:00
committed by GitHub
parent d6768ba12e
commit bd801ad8da
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/dashboard/browser/interfaces.ts
View File

@@ -60,7 +60,7 @@ export interface IModelStore {
getComponentDescriptor(componentId: string): IComponentDescriptor; getComponentDescriptor(componentId: string): IComponentDescriptor;
registerComponent(component: IComponent): void; registerComponent(component: IComponent): void;
unregisterComponent(component: IComponent): void; unregisterComponent(component: IComponent): void;
getComponent(componentId: string): IComponent; getComponent(componentId: string): IComponent | undefined;
/** /**
* Runs on a component immediately if the component exists, or runs on * Runs on a component immediately if the component exists, or runs on
* registration of the component otherwise * registration of the component otherwise

2
src/sql/workbench/browser/modelComponents/componentBase.ts
View File

@@ -286,7 +286,7 @@ export abstract class ContainerBase<T> extends ComponentBase {
super(_changeRef, _el); super(_changeRef, _el);
this.items = []; this.items = [];
this._validations.push(() => this.items.every(item => { this._validations.push(() => this.items.every(item => {
return this.modelStore.getComponent(item.descriptor.id).valid; return this.modelStore.getComponent(item.descriptor.id)?.valid || false;
})); }));
} }

2
src/sql/workbench/browser/modelComponents/modelStore.ts
View File

@@ -47,7 +47,7 @@ export class ModelStore implements IModelStore {
// TODO notify model for cleanup // TODO notify model for cleanup
} }
getComponent(componentId: string): IComponent { getComponent(componentId: string): IComponent | undefined {
return this._componentMappings[componentId]; return this._componentMappings[componentId];
} }