ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix telemetry for Sql db projects (#14896)

Browse Source
This commit is contained in:
Sakshi Sharma
2021-03-29 12:20:56 -07:00
committed by GitHub
parent 4c5a4215f8
commit bdbe4fb6de
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/sql-database-projects/src/controllers/projectController.ts
View File

@@ -122,13 +122,13 @@ export class ProjectsController {
await this.netCoreTool.runDotnetCommand(options); await this.netCoreTool.runDotnetCommand(options);
TelemetryReporter.createActionEvent(TelemetryViews.ProjectController, TelemetryActions.build) TelemetryReporter.createActionEvent(TelemetryViews.ProjectController, TelemetryActions.build)
.withAdditionalMeasurements({ duration: new Date().getMilliseconds() - startTime.getMilliseconds() }) .withAdditionalMeasurements({ duration: new Date().getTime() - startTime.getTime() })
.send(); .send();
return project.dacpacOutputPath; return project.dacpacOutputPath;
} catch (err) { } catch (err) {
TelemetryReporter.createErrorEvent(TelemetryViews.ProjectController, TelemetryActions.build) TelemetryReporter.createErrorEvent(TelemetryViews.ProjectController, TelemetryActions.build)
.withAdditionalMeasurements({ duration: new Date().getMilliseconds() - startTime.getMilliseconds() }) .withAdditionalMeasurements({ duration: new Date().getTime() - startTime.getTime() })
.send(); .send();
vscode.window.showErrorMessage(constants.projBuildFailed(utils.getErrorMessage(err))); vscode.window.showErrorMessage(constants.projBuildFailed(utils.getErrorMessage(err)));
@@ -162,11 +162,11 @@ export class ProjectsController {
public async publishProjectCallback(project: Project, settings: IPublishSettings | IGenerateScriptSettings): Promise<mssql.DacFxResult | undefined> { public async publishProjectCallback(project: Project, settings: IPublishSettings | IGenerateScriptSettings): Promise<mssql.DacFxResult | undefined> {
const telemetryProps: Record<string, string> = {}; const telemetryProps: Record<string, string> = {};
const telemetryMeasures: Record<string, number> = {}; const telemetryMeasures: Record<string, number> = {};
const buildStartTime = new Date().getMilliseconds(); const buildStartTime = new Date().getTime();
const dacpacPath = await this.buildProject(project); const dacpacPath = await this.buildProject(project);
const buildEndTime = new Date().getMilliseconds(); const buildEndTime = new Date().getTime();
telemetryMeasures.buildDuration = buildEndTime - buildStartTime; telemetryMeasures.buildDuration = buildEndTime - buildStartTime;
telemetryProps.buildSucceeded = (dacpacPath !== '').toString(); telemetryProps.buildSucceeded = (dacpacPath !== '').toString();
@@ -187,7 +187,7 @@ export class ProjectsController {
let result: mssql.DacFxResult; let result: mssql.DacFxResult;
telemetryProps.profileUsed = (settings.profileUsed ?? false).toString(); telemetryProps.profileUsed = (settings.profileUsed ?? false).toString();
const actionStartTime = new Date().getMilliseconds(); const actionStartTime = new Date().getTime();
try { try {
if ((<IPublishSettings>settings).upgradeExisting) { if ((<IPublishSettings>settings).upgradeExisting) {
@@ -199,7 +199,7 @@ export class ProjectsController {
result = await dacFxService.generateDeployScript(tempPath, settings.databaseName, settings.connectionUri, azdata.TaskExecutionMode.script, settings.sqlCmdVariables, settings.deploymentOptions); result = await dacFxService.generateDeployScript(tempPath, settings.databaseName, settings.connectionUri, azdata.TaskExecutionMode.script, settings.sqlCmdVariables, settings.deploymentOptions);
} }
} catch (err) { } catch (err) {
const actionEndTime = new Date().getMilliseconds(); const actionEndTime = new Date().getTime();
telemetryProps.actionDuration = (actionEndTime - actionStartTime).toString(); telemetryProps.actionDuration = (actionEndTime - actionStartTime).toString();
telemetryProps.totalDuration = (actionEndTime - buildStartTime).toString(); telemetryProps.totalDuration = (actionEndTime - buildStartTime).toString();
@@ -210,7 +210,7 @@ export class ProjectsController {
throw err; throw err;
} }
const actionEndTime = new Date().getMilliseconds(); const actionEndTime = new Date().getTime();
telemetryProps.actionDuration = (actionEndTime - actionStartTime).toString(); telemetryProps.actionDuration = (actionEndTime - actionStartTime).toString();
telemetryProps.totalDuration = (actionEndTime - buildStartTime).toString(); telemetryProps.totalDuration = (actionEndTime - buildStartTime).toString();
@@ -610,11 +610,11 @@ export class ProjectsController {
const streamingJobDefinition: string = (await fs.readFile(node.element.fileSystemUri.fsPath)).toString(); const streamingJobDefinition: string = (await fs.readFile(node.element.fileSystemUri.fsPath)).toString();
const dacFxService = await this.getDaxFxService(); const dacFxService = await this.getDaxFxService();
const actionStartTime = new Date().getMilliseconds(); const actionStartTime = new Date().getTime();
const result: mssql.ValidateStreamingJobResult = await dacFxService.validateStreamingJob(dacpacPath, streamingJobDefinition); const result: mssql.ValidateStreamingJobResult = await dacFxService.validateStreamingJob(dacpacPath, streamingJobDefinition);
const duration = new Date().getMilliseconds() - actionStartTime; const duration = new Date().getTime() - actionStartTime;
telemetryProps.success = result.success.toString(); telemetryProps.success = result.success.toString();
if (result.success) { if (result.success) {