From bf82204453ccfc39348e1a6131412ad7c4b78c9c Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Tue, 19 Apr 2022 17:28:27 -0700 Subject: [PATCH] add sdk-style option to exposed sql project apis (#19143) --- .../src/projectProvider/projectProvider.ts | 4 +++- extensions/sql-database-projects/src/sqldbproj.d.ts | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/extensions/sql-database-projects/src/projectProvider/projectProvider.ts b/extensions/sql-database-projects/src/projectProvider/projectProvider.ts index 189cadcc3e..b1f121fbaf 100644 --- a/extensions/sql-database-projects/src/projectProvider/projectProvider.ts +++ b/extensions/sql-database-projects/src/projectProvider/projectProvider.ts @@ -74,9 +74,11 @@ export class SqlDatabaseProjectProvider implements dataworkspace.IProjectProvide * @param name name of the project * @param location the parent directory * @param projectTypeId the ID of the project/template + * @param targetPlatform the target platform of the project + * @param sdkStyle whether project is sdk-style. Default is false * @returns Uri of the newly created project file */ - async createProject(name: string, location: vscode.Uri, projectTypeId: string, targetPlatform?: sqldbproj.SqlTargetPlatform, sdkStyle: boolean = true): Promise { + async createProject(name: string, location: vscode.Uri, projectTypeId: string, targetPlatform?: sqldbproj.SqlTargetPlatform, sdkStyle: boolean = false): Promise { if (!targetPlatform) { const projectType = this.supportedProjectTypes.find(x => x.id === projectTypeId); diff --git a/extensions/sql-database-projects/src/sqldbproj.d.ts b/extensions/sql-database-projects/src/sqldbproj.d.ts index 18002ac1ca..d0c7f0613a 100644 --- a/extensions/sql-database-projects/src/sqldbproj.d.ts +++ b/extensions/sql-database-projects/src/sqldbproj.d.ts @@ -20,9 +20,10 @@ declare module 'sqldbproj' { * @param location the parent directory * @param projectTypeId the ID of the project/template * @param targetPlatform the target platform for the project. Default is SQL Server 2019 + * @param sdkStyle whether the project is sdk-style. Default is false * @returns Uri of the newly created project file */ - createProject(name: string, location: vscode.Uri, projectTypeId: string, targetPlatform: SqlTargetPlatform): Promise; + createProject(name: string, location: vscode.Uri, projectTypeId: string, targetPlatform: SqlTargetPlatform, sdkStyle?: boolean): Promise; /** * Opens and loads a .sqlproj file