ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] SKU recommendation improvements + SQL DB integration bug fixes (#20174)

Browse Source 
* WIP - show error message for failed SKU recommendation

* WIP - run query to get correct instance name

* WIP - integrate elastic model recommendation

* Remove private endpoint restriction text

* Add feature switch for elastic recommendation

* Clean up

* Clean up

* Misc UI fixes

* Update package.json with updated azdata dependency

* Remove unused lines

* Fix broken next button

* Vbump extension to 1.0.6

* Update SQL DB card to show number of recommendations for correct model
This commit is contained in:
Raymond Truong
2022-08-26 14:06:33 -07:00
committed by GitHub
parent bd0c4cdb51
commit bfcbd60d24
12 changed files with 300 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/sql-migration/src/wizard/databaseBackupPage.ts
View File

@@ -413,14 +413,6 @@ export class DatabaseBackupPage extends MigrationWizardPage {
CSSStyles: { ...styles.SECTION_HEADER_CSS }
}).component();
const azureStoragePrivateEndpointInfoBox = this._view.modelBuilder.infoBox()
.withProps({
text: constants.DATABASE_BACKUP_PRIVATE_ENDPOINT_INFO_TEXT,
style: 'information',
width: WIZARD_INPUT_COMPONENT_WIDTH,
CSSStyles: { ...styles.BODY_CSS }
}).component();
this._networkShareTargetDatabaseNamesTable = this._view.modelBuilder.declarativeTable()
.withProps({
columns: [
@@ -523,7 +515,6 @@ export class DatabaseBackupPage extends MigrationWizardPage {
.withItems([
blobTableText,
allFieldsRequiredLabel,
azureStoragePrivateEndpointInfoBox,
this._blobContainerTargetDatabaseNamesTable])
.withProps({ CSSStyles: { 'display': 'none', } })
.component();
@@ -553,14 +544,6 @@ export class DatabaseBackupPage extends MigrationWizardPage {
CSSStyles: { ...styles.BODY_CSS, 'margin-bottom': '12px' }
}).component();
const azureStoragePrivateEndpointInfoBox = this._view.modelBuilder.infoBox()
.withProps({
text: constants.DATABASE_BACKUP_PRIVATE_ENDPOINT_INFO_TEXT,
style: 'information',
width: WIZARD_INPUT_COMPONENT_WIDTH,
CSSStyles: { ...styles.BODY_CSS }
}).component();
const subscriptionLabel = this._view.modelBuilder.text()
.withProps({
value: constants.SUBSCRIPTION,
@@ -673,7 +656,6 @@ export class DatabaseBackupPage extends MigrationWizardPage {
.withItems([
azureAccountHeader,
azureAccountHelpText,
azureStoragePrivateEndpointInfoBox,
subscriptionLabel,
this._networkShareContainerSubscription,
locationLabel,