From f8da5bd1c7201f686dfd24b639dfa1bfeba38d4d Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Mon, 6 May 2019 11:36:06 -0700 Subject: [PATCH 1/4] Don't scroll when running code cell if in view (#5365) --- src/sql/workbench/parts/notebook/cellViews/code.component.ts | 2 +- .../workbench/parts/notebook/cellViews/textCell.component.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sql/workbench/parts/notebook/cellViews/code.component.ts b/src/sql/workbench/parts/notebook/cellViews/code.component.ts index f78c4d686e..231209a6b5 100644 --- a/src/sql/workbench/parts/notebook/cellViews/code.component.ts +++ b/src/sql/workbench/parts/notebook/cellViews/code.component.ts @@ -306,7 +306,7 @@ export class CodeComponent extends AngularDisposable implements OnInit, OnChange private setFocusAndScroll(): void { if (this.cellModel.id === this._activeCellId) { this._editor.focus(); - this._editor.getContainer().scrollIntoView(); + this._editor.getContainer().scrollIntoView({ behavior: 'smooth', block: 'nearest' }); } } diff --git a/src/sql/workbench/parts/notebook/cellViews/textCell.component.ts b/src/sql/workbench/parts/notebook/cellViews/textCell.component.ts index 9d9412efee..77e9fed623 100644 --- a/src/sql/workbench/parts/notebook/cellViews/textCell.component.ts +++ b/src/sql/workbench/parts/notebook/cellViews/textCell.component.ts @@ -287,7 +287,7 @@ export class TextCellComponent extends CellView implements OnInit, AfterContentI this.toggleEditMode(this.isActive()); if (this.output && this.output.nativeElement) { - (this.output.nativeElement).scrollTo(); + (this.output.nativeElement).scrollTo({ behavior: 'smooth' }); } } From 59cc8e5d7f2a3987c787b120ed0e632ec9546a04 Mon Sep 17 00:00:00 2001 From: Karl Burtram Date: Mon, 6 May 2019 17:02:51 -0700 Subject: [PATCH 2/4] Bump the VS Code version metadata (#5392) --- product.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/product.json b/product.json index be7aaaaf6c..fc130972ac 100644 --- a/product.json +++ b/product.json @@ -34,7 +34,7 @@ "gettingStartedUrl": "https://go.microsoft.com/fwlink/?linkid=862039", "releaseNotesUrl": "https://go.microsoft.com/fwlink/?linkid=875578", "documentationUrl": "https://go.microsoft.com/fwlink/?linkid=862277", - "vscodeVersion": "1.31.1", + "vscodeVersion": "1.33.1", "commit": "9ca6200018fc206d67a47229f991901a8a453781", "date": "2017-12-15T12:00:00.000Z", "recommendedExtensions": [ From 2b0aba119d7a5f19b920851aa10f3fbfe7a5036b Mon Sep 17 00:00:00 2001 From: kisantia <31145923+kisantia@users.noreply.github.com> Date: Mon, 6 May 2019 17:10:51 -0700 Subject: [PATCH 3/4] bump dacpac extension version (#5387) --- extensions/dacpac/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/dacpac/package.json b/extensions/dacpac/package.json index 2e6d556c8f..6c044d5a6e 100644 --- a/extensions/dacpac/package.json +++ b/extensions/dacpac/package.json @@ -2,7 +2,7 @@ "name": "dacpac", "displayName": "SQL Server Dacpac", "description": "SQL Server Dacpac for Azure Data Studio.", - "version": "0.1.0", + "version": "0.2.0", "publisher": "Microsoft", "preview": true, "engines": { From 1c694cbd3bfccbbd17cb68a65c7731ccc5f4e3dd Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Mon, 6 May 2019 17:25:51 -0700 Subject: [PATCH 4/4] Fix css to fix new dashboard tab dialog (#5385) * fix css to fix new dashboard tab dialog * add readonly --- .../dashboard/browser/media/newDashboardTabDialog.css | 5 ++++- .../dashboard/browser/newDashboardTabDialog.ts | 10 +++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css b/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css index 7a08c2e0f9..5b1dc8cffa 100644 --- a/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css +++ b/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css @@ -47,6 +47,7 @@ .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .title { font-size: 15px; + line-height: 1.4em; font-weight: 700; white-space: nowrap; text-overflow: ellipsis; @@ -56,6 +57,7 @@ .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .description { font-size: 13px; + line-height: 1.4em; overflow: hidden; white-space: pre-wrap; text-overflow: ellipsis; @@ -63,6 +65,7 @@ .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .publisher { font-size: 90%; + line-height: 1.4em; padding-right: 6px; opacity: .6; font-weight: 600; @@ -71,4 +74,4 @@ .no-extensionTab-label { font-size: 12px; padding: 15px; -} \ No newline at end of file +} diff --git a/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts b/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts index 06c16ae4f6..f112a675c3 100644 --- a/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts +++ b/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts @@ -29,13 +29,10 @@ import { IWorkbenchLayoutService } from 'vs/workbench/services/layout/browser/la class ExtensionListDelegate implements IListVirtualDelegate { - constructor( - private _height: number - ) { - } + private static readonly HEIGHT = 101; public getHeight(element: IDashboardUITab): number { - return this._height; + return ExtensionListDelegate.HEIGHT; } public getTemplateId(element: IDashboardUITab): string { @@ -91,7 +88,6 @@ class ExtensionListRenderer implements IListRenderer(extensionTabViewContainer, delegate, [extensionTabRenderer]);