From c03cce7f60b2815c8a4b4e15af207d15f8c284f5 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Fri, 22 Nov 2019 16:05:57 -0800 Subject: [PATCH] set aria label for table (#8443) --- .../resource-deployment/src/ui/resourceTypePickerDialog.ts | 3 ++- src/sql/base/browser/ui/table/table.ts | 4 ++++ src/sql/workbench/browser/modelComponents/table.component.ts | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts b/extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts index e844e1da8a..812b8c681f 100644 --- a/extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts +++ b/extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts @@ -92,7 +92,8 @@ export class ResourceTypePickerDialog extends DialogBase { this._toolsTable = view.modelBuilder.table().withProperties({ data: [], columns: [toolColumn, descriptionColumn, installStatusColumn, versionColumn, minVersionColumn], - width: tableWidth + width: tableWidth, + ariaLabel: localize('deploymentDialog.RequiredToolsTitle', "Required tools") }).component(); const toolsTableWrapper = view.modelBuilder.divContainer().withLayout({ width: tableWidth }).component(); diff --git a/src/sql/base/browser/ui/table/table.ts b/src/sql/base/browser/ui/table/table.ts index 27dee900cd..11dd1db8f2 100644 --- a/src/sql/base/browser/ui/table/table.ts +++ b/src/sql/base/browser/ui/table/table.ts @@ -364,4 +364,8 @@ export class Table extends Widget implements IDisposa public set ariaRole(value: string) { this._tableContainer.setAttribute('role', value); } + + public set ariaLabel(value: string) { + this._tableContainer.setAttribute('aria-label', value); + } } diff --git a/src/sql/workbench/browser/modelComponents/table.component.ts b/src/sql/workbench/browser/modelComponents/table.component.ts index a9c3c2f78b..fa80e00585 100644 --- a/src/sql/workbench/browser/modelComponents/table.component.ts +++ b/src/sql/workbench/browser/modelComponents/table.component.ts @@ -252,6 +252,10 @@ export default class TableComponent extends ComponentBase implements IComponent, this._table.ariaRole = this.ariaRole; } + if (this.ariaLabel) { + this._table.ariaLabel = this.ariaLabel; + } + if (this.updateCells !== undefined) { this.updateTableCells(this.updateCells); }