ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)

Browse Source 
* Fixes bug around copying user codes and opening a browser tab.

* Code review changes

* Additional review changes.

* Unnecessary import removed
This commit is contained in:
Lewis Sanchez
2021-11-30 10:37:56 -08:00
committed by GitHub
parent 917a30e66f
commit c073897056
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/accounts/common/interfaces.ts
View File

@@ -35,7 +35,7 @@ export interface IAccountManagementService {
beginAutoOAuthDeviceCode(providerId: string, title: string, message: string, userCode: string, uri: string): Promise<void>;
endAutoOAuthDeviceCode(): void;
cancelAutoOAuthDeviceCode(providerId: string): void;
copyUserCodeAndOpenBrowser(userCode: string, uri: string): void;
copyUserCodeAndOpenBrowser(userCode: string, uri: string): Promise<void>;
// SERVICE MANAGEMENT METHODS /////////////////////////////////////////
registerProvider(providerMetadata: azdata.AccountProviderMetadata, provider: azdata.AccountProvider): void;

4
src/sql/platform/accounts/test/common/testAccountManagementService.ts
View File

@@ -35,8 +35,8 @@ export class TestAccountManagementService implements IAccountManagementService {
return undefined;
}
copyUserCodeAndOpenBrowser(userCode: string, uri: string): void {
return undefined;
async copyUserCodeAndOpenBrowser(userCode: string, uri: string): Promise<void> {
return;
}
getAccountProviderMetadata(): Promise<azdata.AccountProviderMetadata[]> {