ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-04 17:23:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Various results grid scrolling fixes (#5285)

Browse Source
This commit is contained in:
Karl Burtram
2019-05-01 12:36:16 -07:00
committed by GitHub
parent 104b99ffa0
commit c1cb9000a9
5 changed files with 42 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/sql/workbench/parts/query/electron-browser/gridPanel.ts
View File

@@ -297,13 +297,18 @@ export class GridPanel extends ViewletPanel {
tables.push(table);
}
// possible to need a sort?
this.tables = this.tables.concat(tables);
// turn-off special-case process when only a single table is being displayed
if (this.tables.length > 1) {
for (let i = 0; i < this.tables.length; ++i) {
this.tables[i].isOnlyTable = false;
}
}
if (isUndefinedOrNull(this.maximizedGrid)) {
this.splitView.addViews(tables, tables.map(i => i.minimumSize), this.splitView.length);
}
this.tables = this.tables.concat(tables);
}
public clear() {
@@ -404,6 +409,8 @@ class GridTable<T> extends Disposable implements IView {
private rowHeight: number;
public isOnlyTable: boolean = true;
public get resultSet(): azdata.ResultSetSummary {
return this._resultSet;
}
@@ -713,7 +720,8 @@ class GridTable<T> extends Disposable implements IView {
public get minimumSize(): number {
// clamp between ensuring we can show the actionbar, while also making sure we don't take too much space
return Math.max(Math.min(this.maxSize, MIN_GRID_HEIGHT), ACTIONBAR_HEIGHT + BOTTOM_PADDING);
// if there is only one table then allow a minimum size of ROW_HEIGHT
return this.isOnlyTable ? ROW_HEIGHT : Math.max(Math.min(this.maxSize, MIN_GRID_HEIGHT), ACTIONBAR_HEIGHT + BOTTOM_PADDING);
}
public get maximumSize(): number {