ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix errors due to icon to codicon rename in VSCode (#7837)

Browse Source 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
This commit is contained in:
Kevin Cunnane
2019-10-21 12:02:30 -07:00
committed by GitHub
parent 53a081262d
commit c1e95a2246
41 changed files with 114 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sql/base/parts/editableDropdown/browser/media/dropdownList.css
View File

@@ -3,16 +3,16 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
.vs .dropdown-arrow.icon {
.vs .dropdown-arrow.codicon {
background-image: url("dropdownarrow.svg");
}
.vs-dark .dropdown-arrow.icon,
.hc-black .dropdown-arrow.icon {
.vs-dark .dropdown-arrow.codicon,
.hc-black .dropdown-arrow.codicon {
background-image: url("dropdownarrow_inverse.svg");
}
.monaco-dropdown .monaco-action-bar .action-label.icon.dropdown-arrow {
.monaco-dropdown .monaco-action-bar .action-label.codicon.dropdown-arrow {
padding: 0;
background-size: 10px;
background-position: 50%;
@@ -38,12 +38,12 @@
overflow: hidden;
}
.connection-input .monaco-dropdown .monaco-action-bar .action-label.icon.dropdown-arrow {
.connection-input .monaco-dropdown .monaco-action-bar .action-label.codicon.dropdown-arrow {
background-position: 50%;
background-size: cover;
}
.connection-input .monaco-inputbox .monaco-action-bar .action-item .icon {
.connection-input .monaco-inputbox .monaco-action-bar .action-item .codicon {
width: 8px;
height: 8px;
}