Inital platform relayering (#6385)

* moving test files and inital refactoring

* relayer extension host code

* fix imports

* make insights work

* relayer dashboard

* relayer notebooks

* moveing more code around

* formatting

* accept angular as browser

* fix serializer

* add missing files

* remove declarations from extensions

* fix build errors

* more relayering

* change urls to relative to help code relayering

* remove layering to prep for merge

* fix hygiene errors

* fix hygiene errors

* fix tests

src/sql/workbench/parts/dataExplorer/electron-browser/nodeCommands.ts

@@ -15,8 +15,8 @@ import { CommandsRegistry, ICommandService } from 'vs/platform/commands/common/c
 import { IViewsRegistry, Extensions } from 'vs/workbench/common/views';
 import { IProgressService } from 'vs/platform/progress/common/progress';
 import { Registry } from 'vs/platform/registry/common/platform';
-import { NewNotebookAction } from 'sql/workbench/parts/notebook/notebookActions';
 import { BackupAction, RestoreAction } from 'sql/workbench/common/actions';
+import { NewNotebookAction } from 'sql/workbench/parts/notebook/electron-browser/notebookActions';
 
 export const DISCONNECT_COMMAND_ID = 'dataExplorer.disconnect';
 export const MANAGE_COMMAND_ID = 'dataExplorer.manage';

src/sql/workbench/parts/dataExplorer/test/browser/dataExplorerViewlet.test.ts

@@ -0,0 +1,55 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as assert from 'assert';
+import * as Platform from 'vs/platform/registry/common/platform';
+import { ViewletDescriptor, Extensions, Viewlet, ViewletRegistry } from 'vs/workbench/browser/viewlet';
+import * as Types from 'vs/base/common/types';
+
+suite('Data Explorer Viewlet', () => {
+
+	class DataExplorerTestViewlet extends Viewlet {
+
+		constructor() {
+			super('dataExplorer', null, null, null, null, null);
+		}
+
+		public layout(dimension: any): void {
+			throw new Error('Method not implemented.');
+		}
+	}
+
+	test('ViewletDescriptor API', function () {
+		let d = new ViewletDescriptor(DataExplorerTestViewlet, 'id', 'name', 'class', 1);
+		assert.strictEqual(d.id, 'id');
+		assert.strictEqual(d.name, 'name');
+		assert.strictEqual(d.cssClass, 'class');
+		assert.strictEqual(d.order, 1);
+	});
+
+	test('Editor Aware ViewletDescriptor API', function () {
+		let d = new ViewletDescriptor(DataExplorerTestViewlet, 'id', 'name', 'class', 5);
+		assert.strictEqual(d.id, 'id');
+		assert.strictEqual(d.name, 'name');
+
+		d = new ViewletDescriptor(DataExplorerTestViewlet, 'id', 'name', 'class', 5);
+		assert.strictEqual(d.id, 'id');
+		assert.strictEqual(d.name, 'name');
+	});
+
+	test('Data Explorer Viewlet extension point and registration', function () {
+		assert(Types.isFunction(Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).registerViewlet));
+		assert(Types.isFunction(Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlet));
+		assert(Types.isFunction(Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlets));
+
+		let oldCount = Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlets().length;
+		let d = new ViewletDescriptor(DataExplorerTestViewlet, 'dataExplorer-test-id', 'name');
+		Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).registerViewlet(d);
+		let retrieved = Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlet('dataExplorer-test-id');
+		assert(d === retrieved);
+		let newCount = Platform.Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlets().length;
+		assert.equal(oldCount + 1, newCount);
+	});
+});