ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-31 17:23:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

limit the data size for chart rendering (#14949)

Browse Source 
* limit the rows feed to charts

* add telemetry and option to hide

* fix typo

* updates

* comments

* notebook fix
This commit is contained in:
Alan Ren
2021-04-02 19:36:10 -07:00
committed by GitHub
parent 13ad4c9497
commit c2d2cf5a82
11 changed files with 151 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/sql/workbench/contrib/notebook/browser/outputs/gridOutput.component.ts
View File

@@ -44,6 +44,11 @@ import { assign } from 'vs/base/common/objects';
import { QueryResultId } from 'sql/workbench/services/notebook/browser/models/cell';
import { equals } from 'vs/base/common/arrays';
import { IDisposableDataProvider } from 'sql/base/common/dataProvider';
import { IStorageService } from 'vs/platform/storage/common/storage';
import { getChartMaxRowCount, notifyMaxRowCountExceeded } from 'sql/workbench/contrib/charts/browser/utils';
import { IAdsTelemetryService } from 'sql/platform/telemetry/common/telemetry';
import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
@Component({
selector: GridOutputComponent.SELECTOR,
template: `<div #output class="notebook-cellTable"></div>`
@@ -284,8 +289,9 @@ class DataResourceTable extends GridTableBase<any> {
public updateChartData(rowCount: number, columnCount: number, gridDataProvider: IGridDataProvider): void {
if (this.chartDisplayed) {
gridDataProvider.getRowData(0, rowCount).then(result => {
let range = new Slick.Range(0, 0, rowCount - 1, columnCount - 1);
const actualRowCount = Math.min(getChartMaxRowCount(this.configurationService), rowCount);
gridDataProvider.getRowData(0, actualRowCount).then(result => {
let range = new Slick.Range(0, 0, actualRowCount - 1, columnCount - 1);
let columns = gridDataProvider.getColumnHeaders(range);
this._chart.setData(result.rows, columns);
});
@@ -535,7 +541,11 @@ export class NotebookChartAction extends ToggleableAction {
public static SHOWTABLE_LABEL = localize('notebook.showTable', "Show table");
public static SHOWTABLE_ICON = 'table';
constructor(private resourceTable: DataResourceTable) {
constructor(private resourceTable: DataResourceTable,
@IConfigurationService private readonly configurationService: IConfigurationService,
@IStorageService private readonly storageService: IStorageService,
@INotificationService private readonly notificationService: INotificationService,
@IAdsTelemetryService private readonly adsTelemetryService: IAdsTelemetryService) {
super(NotebookChartAction.ID, {
toggleOnLabel: NotebookChartAction.SHOWTABLE_LABEL,
toggleOnClass: NotebookChartAction.SHOWTABLE_ICON,
@@ -549,9 +559,17 @@ export class NotebookChartAction extends ToggleableAction {
this.resourceTable.toggleChartVisibility();
this.toggle(!this.state.isOn);
if (this.state.isOn) {
let rowCount = context.table.getData().getLength();
let columnCount = context.table.columns.length;
this.resourceTable.updateChartData(rowCount, columnCount, context.gridDataProvider);
const rowCount = context.table.getData().getLength();
const columnCount = context.table.columns.length;
const maxRowCount = getChartMaxRowCount(this.configurationService);
const maxRowCountExceeded = rowCount > maxRowCount;
if (maxRowCountExceeded) {
notifyMaxRowCountExceeded(this.storageService, this.notificationService, this.configurationService);
}
this.adsTelemetryService.createActionEvent(TelemetryKeys.TelemetryView.Notebook, TelemetryKeys.TelemetryAction.ShowChart).withAdditionalProperties(
{ [TelemetryKeys.TelemetryPropertyName.ChartMaxRowCountExceeded]: maxRowCountExceeded }
).send();
this.resourceTable.updateChartData(Math.min(rowCount, maxRowCount), columnCount, context.gridDataProvider);
}
return true;
}