ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix parseAclPermissionFromOctal to include optional sticky bit (#7542)

Browse Source 
* Fix parseAclPermissionFromOctal to include optional sticky bit

* Fix doc
This commit is contained in:
Charles Gagnon
2019-10-07 17:21:08 -07:00
committed by GitHub
parent de72ab176c
commit c4965c7fe9
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
extensions/mssql/src/hdfs/aclEntry.ts
View File

@@ -236,29 +236,34 @@ export function parseAclEntry(aclString: string): AclEntry {
} }
/** /**
* Parses an octal in the form ### into a set of @see AclEntryPermission. Each digit in the octal corresponds * Parses an octal in the form [#]### into a combination of an optional sticky bit and a set
* to a particular user type - owner, group and other respectively. * of @see AclEntryPermission. Each digit in the octal corresponds to the sticky bit or a
* Each digit is then expected to be a value between 0 and 7 inclusive, which is a bitwise OR the permission flags * particular user type - owner, group and other respectively.
* If the sticky bit exists and its value is 1 then the sticky bit value is set to true.
* Each permission digit is then expected to be a value between 0 and 7 inclusive, which is a bitwise OR the permission flags
* for the file. * for the file.
* 4 - Read * 4 - Read
* 2 - Write * 2 - Write
* 1 - Execute * 1 - Execute
* So an octal of 730 would map to : * So an octal of 1730 would map to :
* - sticky === true
* - The owner with rwx permissions * - The owner with rwx permissions
* - The group with -wx permissions * - The group with -wx permissions
* - All others with --- permissions * - All others with --- permissions
* @param octal The octal string to parse * @param octal The octal string to parse
*/ */
export function parseAclPermissionFromOctal(octal: string): { owner: AclEntryPermission, group: AclEntryPermission, other: AclEntryPermission } { export function parseAclPermissionFromOctal(octal: string): { sticky: boolean, owner: AclEntryPermission, group: AclEntryPermission, other: AclEntryPermission } {
if (!octal || octal.length !== 3) { if (!octal || (octal.length !== 3 && octal.length !== 4)) {
throw new Error(`Invalid octal ${octal} - it must be a 3 digit string`); throw new Error(`Invalid octal ${octal} - it must be a 3 or 4 digit string`);
} }
const ownerPermissionDigit = parseInt(octal[0]); const sticky = octal.length === 4 ? octal[0] === '1' : false;
const groupPermissionDigit = parseInt(octal[1]); const ownerPermissionDigit = parseInt(octal[octal.length - 3]);
const otherPermissionDigit = parseInt(octal[2]); const groupPermissionDigit = parseInt(octal[octal.length - 2]);
const otherPermissionDigit = parseInt(octal[octal.length - 1]);
return { return {
sticky: sticky,
owner: new AclEntryPermission((ownerPermissionDigit & 4) === 4, (ownerPermissionDigit & 2) === 2, (ownerPermissionDigit & 1) === 1), owner: new AclEntryPermission((ownerPermissionDigit & 4) === 4, (ownerPermissionDigit & 2) === 2, (ownerPermissionDigit & 1) === 1),
group: new AclEntryPermission((groupPermissionDigit & 4) === 4, (groupPermissionDigit & 2) === 2, (groupPermissionDigit & 1) === 1), group: new AclEntryPermission((groupPermissionDigit & 4) === 4, (groupPermissionDigit & 2) === 2, (groupPermissionDigit & 1) === 1),
other: new AclEntryPermission((otherPermissionDigit & 4) === 4, (otherPermissionDigit & 2) === 2, (otherPermissionDigit & 1) === 1) other: new AclEntryPermission((otherPermissionDigit & 4) === 4, (otherPermissionDigit & 2) === 2, (otherPermissionDigit & 1) === 1)