Bug/accessibility 1 (#6774)

* fixing simple name changes

* Fixing button color and tabbing on tabs

* removing some extra lines of code

* Adding some null checks

* Updating as per PR comments
This commit is contained in:
Udeesha Gautam
2019-08-20 10:11:34 -07:00
committed by GitHub
parent 23ed1e9123
commit c513204501
6 changed files with 61 additions and 14 deletions

View File

@@ -271,6 +271,7 @@ export class BackupComponent {
// Set backup path list
this.pathListBox = new ListBox([], this.contextViewService);
this.pathListBox.setAriaLabel(LocalizedStrings.BACKUP_DEVICE);
this.pathListBox.onKeyDown(e => {
if (this.pathListBox.selectedOptions.length > 0) {
const key = e.keyCode;

View File

@@ -63,7 +63,7 @@ export class RestoreDialog extends Modal {
private _scriptButton: Button;
private _restoreButton: Button;
private _closeButton: Button;
private _optionsMap: { [name: string]: Widget } = {};
private _optionsMap: { [name: string]: SelectBox | InputBox | Checkbox } = {};
private _restoreLabel: string;
private _restoreTitle: string;
private _databaseTitle: string;
@@ -250,6 +250,7 @@ export class RestoreDialog extends Modal {
this._restorePlanData = new TableDataView<Slick.SlickData>();
this._restorePlanTable = new Table<Slick.SlickData>(this._restorePlanTableContainer,
{ dataProvider: this._restorePlanData, columns: this._restorePlanColumn }, { enableColumnReorder: false });
this._restorePlanTable.setTableTitle(localize('restorePlan', "Restore plan"));
this._restorePlanTable.setSelectionModel(new RowSelectionModel({ selectActiveRow: false }));
this._restorePlanTable.onSelectedRowsChanged((e, data) => this.backupFileCheckboxChanged(e, data));
@@ -339,7 +340,7 @@ export class RestoreDialog extends Modal {
DOM.append(c, generalTab);
},
layout: () => { },
focus: () => generalTab.focus()
focus: () => this._restoreFromSelectBox ? this._restoreFromSelectBox.focus() : generalTab.focus()
}
});
@@ -351,7 +352,7 @@ export class RestoreDialog extends Modal {
render: c => {
c.appendChild(fileContentElement);
},
focus: () => fileContentElement.focus()
focus: () => this._optionsMap[this._relocateDatabaseFilesOption] ? this._optionsMap[this._relocateDatabaseFilesOption].focus() : fileContentElement.focus()
}
});
@@ -363,7 +364,7 @@ export class RestoreDialog extends Modal {
render: c => {
c.appendChild(optionsContentElement);
},
focus: () => optionsContentElement.focus()
focus: () => this._optionsMap[this._withReplaceDatabaseOption] ? this._optionsMap[this._withReplaceDatabaseOption].focus() : optionsContentElement.focus()
}
});

View File

@@ -96,8 +96,9 @@ export class FileBrowserDialog extends Modal {
ariaLabel: pathLabel
});
this._fileFilterSelectBox = new SelectBox(['*'], '*', this._contextViewService);
let filterLabel = localize('fileFilter', "Files of type");
this._fileFilterSelectBox = new SelectBox(['*'], '*', this._contextViewService);
this._fileFilterSelectBox.setAriaLabel(filterLabel);
let filterBuilder = DialogHelper.appendRow(tableContainer, filterLabel, 'file-input-label', 'file-input-box');
DialogHelper.appendInputSelectBox(filterBuilder, this._fileFilterSelectBox);