ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

table designer improvements (#18206)

Browse Source 
* new table experience

* new table info for existing table

* allow delete confirmation

* fix editor lock isue

* vbump sts

* PR feedback
This commit is contained in:
Alan Ren
2022-02-02 18:46:09 -08:00
committed by GitHub
parent c35eae5969
commit c535c2dbde
14 changed files with 164 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/mssql/src/contracts.ts
View File

@@ -1056,7 +1056,7 @@ export namespace ProcessTableDesignerEditRequest {
}
export namespace PublishTableDesignerChangesRequest {
export const type = new RequestType<azdata.designers.TableInfo, void, void, void>('tabledesigner/publish');
export const type = new RequestType<azdata.designers.TableInfo, azdata.designers.PublishChangesResult, void, void>('tabledesigner/publish');
}
export namespace TableDesignerGenerateScriptRequest {

2
extensions/mssql/src/features.ts
View File

@@ -1131,7 +1131,7 @@ export class TableDesignerFeature extends SqlOpsFeature<undefined> {
}
};
const publishChanges = (tableInfo: azdata.designers.TableInfo): Thenable<void> => {
const publishChanges = (tableInfo: azdata.designers.TableInfo): Thenable<azdata.designers.PublishChangesResult> => {
try {
return client.sendRequest(contracts.PublishTableDesignerChangesRequest.type, tableInfo);
}

3
extensions/mssql/src/tableDesigner/tableDesigner.ts
View File

@@ -31,7 +31,6 @@ export function registerTableDesignerCommands(appContext: AppContext) {
const schema = context.nodeInfo.metadata.schema;
const name = context.nodeInfo.metadata.name;
const connectionString = await azdata.connection.getConnectionString(context.connectionProfile.id, true);
const connectionUri = await azdata.connection.getUriForConnection(context.connectionProfile.id);
const serverInfo = await azdata.connection.getServerInfo(context.connectionProfile.id);
let telemetryInfo: ITelemetryEventProperties = {};
telemetryInfo = Telemetry.fillServerInfo(telemetryInfo, serverInfo);
@@ -41,7 +40,7 @@ export function registerTableDesignerCommands(appContext: AppContext) {
isNewTable: false,
name: name,
schema: schema,
id: `${connectionUri}|${database}|${schema}|${name}`,
id: `${connectionString}|${database}|${schema}|${name}`,
connectionString: connectionString
}, telemetryInfo);
}));