ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-03 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

clean up some disposable use (#6832)

Browse Source
This commit is contained in:
Anthony Dresser
2019-08-20 14:34:13 -07:00
committed by GitHub
parent 54cf062737
commit c540e81108
23 changed files with 139 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sql/platform/scripting/common/scriptingService.ts
View File

@@ -3,8 +3,7 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
import { createDecorator, ServiceIdentifier } from 'vs/platform/instantiation/common/instantiation';
import { IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
import * as azdata from 'azdata';
import { ILogService } from 'vs/platform/log/common/log';
@@ -24,7 +23,7 @@ export enum ScriptOperation {
}
export interface IScriptingService {
_serviceBrand: any;
_serviceBrand: ServiceIdentifier<IScriptingService>;
script(connectionUri: string, metadata: azdata.ObjectMetadata, operation: ScriptOperation, paramDetails: azdata.ScriptingParamDetails): Thenable<azdata.ScriptingResult>;
@@ -51,9 +50,7 @@ export interface IScriptingService {
export class ScriptingService implements IScriptingService {
public _serviceBrand: any;
private disposables: IDisposable[] = [];
public _serviceBrand: ServiceIdentifier<IScriptingService>;
private _providers: { [handle: string]: azdata.ScriptingProvider; } = Object.create(null);
@@ -113,8 +110,4 @@ export class ScriptingService implements IScriptingService {
let provider = this._providers[providerId];
return !!provider;
}
public dispose(): void {
this.disposables = dispose(this.disposables);
}
}