ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-01 17:23:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

clean up some disposable use (#6832)

Browse Source
This commit is contained in:
Anthony Dresser
2019-08-20 14:34:13 -07:00
committed by GitHub
parent 54cf062737
commit c540e81108
23 changed files with 139 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sql/platform/serialization/common/serializationService.ts
View File

@@ -3,8 +3,7 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
import { createDecorator, ServiceIdentifier } from 'vs/platform/instantiation/common/instantiation';
import { IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
import { ICapabilitiesService } from 'sql/platform/capabilities/common/capabilitiesService';
import * as azdata from 'azdata';
@@ -40,7 +39,7 @@ export interface SerializeDataParams {
}
export interface ISerializationService {
_serviceBrand: any;
_serviceBrand: ServiceIdentifier<ISerializationService>;
registerProvider(providerId: string, provider: azdata.SerializationProvider): void;
@@ -62,9 +61,7 @@ function getBatchSize(totalRows: number, currentIndex: number): number {
export class SerializationService implements ISerializationService {
_serviceBrand: any;
private disposables: IDisposable[] = [];
_serviceBrand: ServiceIdentifier<ISerializationService>;
private providers: { providerId: string, provider: azdata.SerializationProvider }[] = [];
@@ -197,8 +194,4 @@ export class SerializationService implements ISerializationService {
};
return continueSerializeRequest;
}
public dispose(): void {
this.disposables = dispose(this.disposables);
}
}