Fix actionbar trigger key handling (#15488)

* Fix actionbar trigger key handling

* fix compile error
This commit is contained in:
Charles Gagnon
2021-05-14 16:31:15 -07:00
committed by GitHub
parent c6a8b80ce5
commit c54f991e60
2 changed files with 11 additions and 16 deletions

View File

@@ -37,6 +37,9 @@ export class ActionBar extends ActionRunner implements IActionRunner {
protected _focusedItem?: number;
protected _focusTracker: DOM.IFocusTracker;
// Trigger Key Tracking
private _triggerKeyDown: boolean = false;
// Elements
protected _domNode: HTMLElement;
protected _actionsList: HTMLElement;
@@ -81,7 +84,7 @@ export class ActionBar extends ActionRunner implements IActionRunner {
} else if (event.equals(KeyCode.Escape)) {
this.cancel();
} else if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) {
// Nothing, just staying out of the else branch
this._triggerKeyDown = true;
} else {
eventHandled = false;
}
@@ -103,7 +106,10 @@ export class ActionBar extends ActionRunner implements IActionRunner {
// Run action on Enter/Space
if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) {
this.doTrigger(event);
if (this._triggerKeyDown) {
this.doTrigger(event);
this._triggerKeyDown = false;
}
event.preventDefault();
event.stopPropagation();
}